Skip to content

add alarms add provider version #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charmingduchess merged 2 commits into from
Sep 25, 2026
Merged

add alarms add provider version #21

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed21c3e
add alarms add provider version
charmingduchess Sep 22, 2026
f173dcc
differentiate log and runtime errors
charmingduchess Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions provisioning/base/resources.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@ provider "aws" {
region = "us-east-1"
}

terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 6.0"
}
}
}

variable "environment" {
type = string
default = "qa"
Expand Down Expand Up @@ -56,3 +65,61 @@ resource "aws_lambda_function" "lambda_instance" {
}
}
}

# Alarms

locals {
log_metric_name = "M2CustomerCodeStoreError"

@KaseyW31 KaseyW31 Sep 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been calling these metrics <ServiceName>LogError

}

data "aws_sns_topic" "rc_alarms" {
name = "research-catalog-team-alarms-${var.environment}"
}

resource "aws_cloudwatch_log_metric_filter" "error_metric_filter" {
name = "${local.log_metric_name}-${var.environment}"
pattern = "{ $.level = \"error\" }"
log_group_name = "/aws/lambda/${aws_lambda_function.lambda_instance.function_name}"

metric_transformation {
name = "${local.log_metric_name}-${var.environment}"
namespace = "LogMetrics"
value = "1"
}
}

resource "aws_cloudwatch_metric_alarm" "log_errors" {
alarm_name = "${local.log_metric_name}Alarm-${var.environment}"
comparison_operator = "GreaterThanThreshold"
evaluation_periods = 1
metric_name = local.log_metric_name
namespace = "LogMetrics"
period = 300
statistic = "Sum"
threshold = 0
alarm_description = "Lambda function ${aws_lambda_function.lambda_instance.function_name} has more than 0 error logs in 5 minutes"
alarm_actions = [data.aws_sns_topic.rc_alarms.arn]
treat_missing_data = "notBreaching"

dimensions = {
FunctionName = aws_lambda_function.lambda_instance.function_name
}
}

resource "aws_cloudwatch_metric_alarm" "lambda_errors" {
alarm_name = "${local.log_metric_name}Alarm-${var.environment}"

@KaseyW31 KaseyW31 Sep 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we decided that alarms should be named <ServiceName>LogErrorAlarm-<env> and <ServiceName>LambdaErrorAlarm-<env> to be more specific about which metric they're configured on

comparison_operator = "GreaterThanThreshold"
evaluation_periods = 1
metric_name = "Errors"
namespace = "AWS/Lambda"
period = 300
statistic = "Sum"
threshold = 0
alarm_description = "Lambda function ${aws_lambda_function.lambda_instance.function_name} has more than 0 errors in 5 minutes"
alarm_actions = [data.aws_sns_topic.rc_alarms.arn]
treat_missing_data = "notBreaching"

dimensions = {
FunctionName = aws_lambda_function.lambda_instance.function_name
}
}
Loading