add alarms add provider version

[charmingduchess]

Added alarms (based on alarms from one of Kasey's PRs). Also added a required provider version since the default one does not support python 3.12 runtime.

Terraform plan output:

Terraform used the selected providers to generate the following execution plan. Resource actions are
indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # module.base.aws_cloudwatch_log_metric_filter.error_metric_filter will be created
  + resource "aws_cloudwatch_log_metric_filter" "error_metric_filter" {
      + apply_on_transformed_logs = (known after apply)
      + id                        = (known after apply)
      + log_group_name            = "/aws/lambda/M2CustomerCodeStore-qa"
      + name                      = "M2CustomerCodeStoreLogError-qa"
      + pattern                   = "{ $.level = \"error\" }"
      + region                    = "us-east-1"

      + metric_transformation {
          + name      = "M2CustomerCodeStoreLogError-qa"
          + namespace = "LogMetrics"
          + unit      = "None"
          + value     = "1"
        }
    }

  # module.base.aws_cloudwatch_metric_alarm.lambda_errors will be created
  + resource "aws_cloudwatch_metric_alarm" "lambda_errors" {
      + actions_enabled                       = true
      + alarm_actions                         = [
          + "arn:aws:sns:us-east-1:946183545209:research-catalog-team-alarms-qa",
        ]
      + alarm_description                     = "Lambda function M2CustomerCodeStore-qa has more than 0 errors in 5 minutes"
      + alarm_name                            = "M2CustomerCodeStoreLambdaErrorAlarm-qa"
      + arn                                   = (known after apply)
      + comparison_operator                   = "GreaterThanThreshold"
      + dimensions                            = {
          + "FunctionName" = "M2CustomerCodeStore-qa"
        }
      + evaluate_low_sample_count_percentiles = (known after apply)
      + evaluation_periods                    = 1
      + id                                    = (known after apply)
      + metric_name                           = "Errors"
      + namespace                             = "AWS/Lambda"
      + period                                = 300
      + region                                = "us-east-1"
      + statistic                             = "Sum"
      + tags_all                              = (known after apply)
      + threshold                             = 0
      + treat_missing_data                    = "notBreaching"
    }

  # module.base.aws_cloudwatch_metric_alarm.log_errors will be created
  + resource "aws_cloudwatch_metric_alarm" "log_errors" {
      + actions_enabled                       = true
      + alarm_actions                         = [
          + "arn:aws:sns:us-east-1:946183545209:research-catalog-team-alarms-qa",
        ]
      + alarm_description                     = "Lambda function M2CustomerCodeStore-qa has more than 0 error logs in 5 minutes"
      + alarm_name                            = "M2CustomerCodeStoreLogErrorAlarm-qa"
      + arn                                   = (known after apply)
      + comparison_operator                   = "GreaterThanThreshold"
      + dimensions                            = {
          + "FunctionName" = "M2CustomerCodeStore-qa"
        }
      + evaluate_low_sample_count_percentiles = (known after apply)
      + evaluation_periods                    = 1
      + id                                    = (known after apply)
      + metric_name                           = "M2CustomerCodeStoreLogError"
      + namespace                             = "LogMetrics"
      + period                                = 300
      + region                                = "us-east-1"
      + statistic                             = "Sum"
      + tags_all                              = (known after apply)
      + threshold                             = 0
      + treat_missing_data                    = "notBreaching"
    }

  # module.base.aws_lambda_function.lambda_instance will be updated in-place
  ~ resource "aws_lambda_function" "lambda_instance" {
        id                             = "M2CustomerCodeStore-qa"
      ~ last_modified                  = "2026-03-25T18:16:33.000+0000" -> (known after apply)
      ~ source_code_hash               = "DW19FkRMN5NiRszf4N3x6ZORd4ITYZwyFhflo3aQMZY=" -> "CKCJkpdIriC+K3xLCxl6FuTnHVr+/eTSumU26p2eYVU="
        tags                           = {}
        # (31 unchanged attributes hidden)

        # (5 unchanged blocks hidden)
    }

  # module.base.aws_s3_object.uploaded_zip will be updated in-place
  ~ resource "aws_s3_object" "uploaded_zip" {
      ~ etag                          = "d22ea36077e2254f12bd4aad8bbdf4f9-5" -> "0d28a5dcac54234eeaa5dea5bbe30200"
        id                            = "m2-customer-code-store-qa-dist.zip"
        tags                          = {}
      + version_id                    = (known after apply)
        # (26 unchanged attributes hidden)
    }

Plan: 3 to add, 2 to change, 0 to destroy.

──────────────────────────────────────────────────

[KaseyW31]

While you were out we just decided on a naming convention to separate out log vs lambda errors, but otherwise looks good to me!

[KaseyW31]

I believe we decided that alarms should be named <ServiceName>LogErrorAlarm-<env> and <ServiceName>LambdaErrorAlarm-<env> to be more specific about which metric they're configured on

[KaseyW31]

I've been calling these metrics <ServiceName>LogError