Skip to content

fix: add spacing between text and link icon in bug report page #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paramveeRana wants to merge 1 commit into
base: develop
Choose a base branch
from
+71 −54
Open

fix: add spacing between text and link icon in bug report page #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 11 additions & 54 deletions packages/uni_app/lib/view/bug_report/bug_report.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import 'package:uni/view/bug_report/widgets/text_field.dart';
import 'package:uni/view/widgets/pages_layouts/secondary/secondary.dart';
import 'package:uni/view/widgets/toast_message.dart';
import 'package:uni_ui/cards/generic_card.dart';
import 'package:uni_ui/cards/link_card.dart';
import 'package:uni_ui/icons.dart';
import 'package:url_launcher/url_launcher.dart';

Expand Down Expand Up @@ -252,61 +253,17 @@ class BugReportPageViewState extends SecondaryPageViewState<BugReportPageView> {
),
),
),
GenericCard(
LinkCard(
icon: UniIcons.github,
title: S.of(context).feedback_github_title_section,
subtitle: 'github.com/NIAEFEUP/uni',
tooltip: S.of(context).feedback_github_title_section,
margin: EdgeInsets.zero,
child: InkWell(
onTap: () async {
final uri = Uri.parse('https://github.com/NIAEFEUP/uni');
if (await canLaunchUrl(uri)) {
await launchUrl(
uri,
mode: LaunchMode.externalApplication,
);
}
},
child: Padding(
padding: const EdgeInsets.symmetric(
horizontal: 16,
vertical: 8,
),
child: Row(
children: [
UniIcon(
UniIcons.github,
size: 30,
color: Theme.of(context).colorScheme.onSecondary,
),
const SizedBox(width: 25),
Expanded(
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Text(
S.of(context).feedback_github_title_section,
style: Theme.of(context).textTheme.bodyLarge,
),
Text(
'github.com/NIAEFEUP/uni',
style: Theme.of(context).textTheme.bodyMedium
?.copyWith(
color: Theme.of(
context,
).colorScheme.onSecondary,
),
),
],
),
),
Icon(
Icons.open_in_new,
size: 25,
color: Theme.of(context).colorScheme.onSecondary,
),
],
),
),
),
onTap: () async {
final uri = Uri.parse('https://github.com/NIAEFEUP/uni');
if (await canLaunchUrl(uri)) {
await launchUrl(uri, mode: LaunchMode.externalApplication);
}
},
),
SizedBox(
width: double.infinity,
Expand Down
60 changes: 60 additions & 0 deletions packages/uni_ui/lib/cards/link_card.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
import 'package:flutter/material.dart';
import 'package:uni_ui/cards/generic_card.dart';
import 'package:uni_ui/icons.dart';

class LinkCard extends StatelessWidget {
const LinkCard({
super.key,
required this.icon,
required this.title,
required this.subtitle,
required this.tooltip,
this.onTap,
this.margin = EdgeInsets.zero,
});

final UniIconData icon;
final String title;
final String subtitle;
final String tooltip;
final VoidCallback? onTap;
final EdgeInsetsGeometry margin;

@override
Widget build(BuildContext context) {
final color = Theme.of(context).colorScheme.onSecondary;

return GenericCard(
tooltip: tooltip,
margin: margin,
child: InkWell(
onTap: onTap,
child: Padding(
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
child: Row(
children: [
UniIcon(icon, size: 30, color: color),
const SizedBox(width: 25),
Expanded(
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Text(title, style: Theme.of(context).textTheme.bodyLarge),
Text(
subtitle,
style: Theme.of(
context,
).textTheme.bodyMedium?.copyWith(color: color),
),
],
),
),
const SizedBox(width: 16),
Icon(Icons.open_in_new, size: 25, color: color),
],
),
),
),
);
}
}