Repository navigation
Conversation
Registers the `samp` (Sample) Discipline LDD namespace requested in #1109 (operations#1635): namespace registry CSV row, config.properties block, and a cucumber test (github1109) with an Ingest LDD and a label. stewardArr is `geo,esa,ads`; `ads` (Astromaterials Data System) is a new code. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Contributor
Author
|
@jshughes please review this PR. I will have another soon for you for the ro-* instrument namespaces. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An active nit remains in the newly added fixture comment because “purposed” and “editted” are misspelled.
1 open issue
What changed in this PR
Adds the new samp (Sample) Discipline namespace to the PDS4 Information Model and namespace registry, with integration-test fixtures covering LDD generation and label validation.
Changes:
- Registers
sampwith its namespace metadata, description, and steward organizations. - Adds the Sample namespace to the public registry and updates the registry timestamp.
- Adds an ingest LDD, passing label, and validation scenario for IM 1.27.0.0 / 1R00.
| File | Description |
|---|---|
| model-ontology/src/ontology/Data/config.properties | Registers the samp Discipline namespace and configures its steward mappings and metadata. |
| model-lddtool/src/test/resources/features/validate.feature | Adds the github1109 integration validation scenario for the new namespace. |
| model-lddtool/src/test/resources/data/update_version/github1109/PDS4_PARTICLE_IngestLDD_samp.xml | Provides the ingest LDD fixture used to generate the Sample namespace dictionary. |
| model-lddtool/src/test/resources/data/update_version/github1109/namespace_samp_Pass_261112.xml | Provides a passing product label exercising the generated samp schema. |
| docs/namespace-registry/pds-namespace-registry.csv | Adds the Sample namespace registry entry and updates the last-modified date. |
Review effort: Lite
| <steward_id>samp</steward_id> | ||
| <namespace_id>samp</namespace_id> | ||
| <comment> | ||
| The purposed of this Ingest LDD file is to test new namespaces. It is an editted clone of the Particle LDD. |
Contributor
Author
|
@jshughes apologies, please ignore this one. I will open a new PR for the 3 open namespace-registry requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Resolves #1109
Adds the
samp(Sample) Discipline namespace requested in NASA-PDS/operations#1635.Changes
docs/namespace-registry/pds-namespace-registry.csv: newsamprow (steward Abigail Knight),Last Updatebumpedmodel-ontology/src/ontology/Data/config.properties: newsampblock (NASA Discipline;stewardArr=geo,esa,ads)model-lddtool/src/test/resources/data/update_version/github1109/: Ingest LDD and passing label for IM 1.27.0.0 / 1R00model-lddtool/src/test/resources/features/validate.feature: new#1109rowNotes for reviewers
ads(Astromaterials Data System) did not exist instewardArrbefore this PR. The operations issue lists three stewards (Geosciences Node, ESA PSA, Astromaterials Data System); the first two map to existing codesgeoandesa.CHANGELOG.mdis left to the release tooling.Testing
mvn clean test: 89 tests, 0 failures, BUILD SUCCESS. The newgithub1109scenario generates thesampLDD and validates the label with 0 errors and 0 warnings.This PR was produced as a dry run of the repo's new
/new-namespaceskill and is opened as a draft.🤖 Generated with Claude Code