Skip to content

Add new namespace samp - #1110

Closed
c-suh wants to merge 1 commit into
mainfrom
feature/new-namespace-issue1109-samp
Closed

c-suh wants to merge 1 commit into
mainfrom
feature/new-namespace-issue1109-samp

Conversation

@c-suh

@c-suh c-suh commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Resolves #1109

Adds the samp (Sample) Discipline namespace requested in NASA-PDS/operations#1635.

Changes

  • docs/namespace-registry/pds-namespace-registry.csv: new samp row (steward Abigail Knight), Last Update bumped
  • model-ontology/src/ontology/Data/config.properties: new samp block (NASA Discipline; stewardArr=geo,esa,ads)
  • model-lddtool/src/test/resources/data/update_version/github1109/: Ingest LDD and passing label for IM 1.27.0.0 / 1R00
  • model-lddtool/src/test/resources/features/validate.feature: new #1109 row

Notes for reviewers

  • New steward code: ads (Astromaterials Data System) did not exist in stewardArr before this PR. The operations issue lists three stewards (Geosciences Node, ESA PSA, Astromaterials Data System); the first two map to existing codes geo and esa.
  • The registry PDF/XLSX are not edited here; CI regenerates them from the CSV after merge. CHANGELOG.md is left to the release tooling.

Testing

mvn clean test: 89 tests, 0 failures, BUILD SUCCESS. The new github1109 scenario generates the samp LDD and validates the label with 0 errors and 0 warnings.

This PR was produced as a dry run of the repo's new /new-namespace skill and is opened as a draft.

🤖 Generated with Claude Code

Registers the `samp` (Sample) Discipline LDD namespace requested in #1109
(operations#1635): namespace registry CSV row, config.properties block, and a
cucumber test (github1109) with an Ingest LDD and a label.

stewardArr is `geo,esa,ads`; `ads` (Astromaterials Data System) is a new code.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@c-suh
c-suh marked this pull request as ready for review November 12, 2026 22:01
@c-suh
c-suh requested a review from a team as a code owner November 12, 2026 22:01
@c-suh
c-suh requested review from jshughes and a lite review from Copilot November 12, 2026 22:01
@c-suh

c-suh commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@jshughes please review this PR. I will have another soon for you for the ro-* instrument namespaces.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active nit remains in the newly added fixture comment because “purposed” and “editted” are misspelled.

1 open issue
What changed in this PR

Adds the new samp (Sample) Discipline namespace to the PDS4 Information Model and namespace registry, with integration-test fixtures covering LDD generation and label validation.

Changes:

  • Registers samp with its namespace metadata, description, and steward organizations.
  • Adds the Sample namespace to the public registry and updates the registry timestamp.
  • Adds an ingest LDD, passing label, and validation scenario for IM 1.27.0.0 / 1R00.
File Description
model-ontology/​src/​ontology/​Data/​config.properties Registers the samp Discipline namespace and configures its steward mappings and metadata.
model-lddtool/​src/​test/​resources/​features/​validate.feature Adds the github1109 integration validation scenario for the new namespace.
model-lddtool/​src/​test/​resources/​data/​update_version/​github1109/​PDS4_PARTICLE_IngestLDD_samp.xml Provides the ingest LDD fixture used to generate the Sample namespace dictionary.
model-lddtool/​src/​test/​resources/​data/​update_version/​github1109/​namespace_samp_Pass_261112.xml Provides a passing product label exercising the generated samp schema.
docs/​namespace-registry/​pds-namespace-registry.csv Adds the Sample namespace registry entry and updates the last-modified date.

Review effort: Lite

<steward_id>samp</steward_id>
<namespace_id>samp</namespace_id>
<comment>
The purposed of this Ingest LDD file is to test new namespaces. It is an editted clone of the Particle LDD.
@c-suh

c-suh commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@jshughes apologies, please ignore this one. I will open a new PR for the 3 open namespace-registry requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[namespace-registry] add new namespace samp

2 participants