Skip to content

Add new namespaces ro-alice, ro-miro, samp - #1111

Merged
c-suh merged 4 commits into
mainfrom
feature/new-namespace-issue1097-1098-1109
Nov 15, 2026
Merged

c-suh merged 4 commits into
mainfrom
feature/new-namespace-issue1097-1098-1109

Conversation

@c-suh

@c-suh c-suh commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Resolves #1097
Resolves #1098
Resolves #1109

Adds three namespaces to the registry and the IM config:

Changes

Testing

mvn clean test: 91 tests, 0 failures, BUILD SUCCESS. Each new scenario (github1097, github1098, github1109) generates its LDD and validates the label with 0 errors and 0 warnings.

The registry PDF/XLSX are not edited here; CI regenerates them from the CSV after merge. CHANGELOG.md is left to the release tooling.

Prior work

No precedent in the repo

  • Hyphenated namespace ids (ro-alice, ro-miro): no existing namespace has one. Done: used as-is. Build generated PDS4_RO-ALICE_1R00_1010.xsd/.sch and PDS4_RO-MIRO_1R00_1010.xsd/.sch and validation passes. Reviewer: confirm the hyphen is acceptable in published schema file names and downstream tooling.
  • New stewardArr code ads (Astromaterials Data System) in samp (geo,psa,ads). Done: added as listed in the operations issue. Reviewer: confirm the code name.
  • New stewardArr combinations pds,psa (ro-alice) and sbn,psa (ro-miro). Done: each code exists, but pds appears only inside pds,img,ops and these pairings are new. The operations issues give free text ("NASA PDS (US Instrument Team) ... in cooperation with ESA/PSA", "SBN (US Instrument Team), in cooperation with ESA PSA"), so the mapping was chosen by the requester of this PR. Reviewer: confirm.
  • Rosetta (an ESA mission) hosted as a NASA Mission: pds.nasa.gov/pds4/, urn:nasa:pds:, PDS4, 0001_NASA_PDS_1, label URI http://pds.nasa.gov/pds4/mission/<ns>/v1. Existing ESA mission namespaces use psa.esa.int/urn:esa:psa:. Reviewer: confirm NASA hosting is intended.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@c-suh
c-suh requested a review from a team as a code owner November 12, 2026 23:14
@c-suh
c-suh requested review from jshughes and a lite review from Copilot November 12, 2026 23:14
@c-suh

c-suh commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@jshughes please review this PR for these 3 namespace requests. Also note the bottom section of the description titled "No precedent in the repo". Thank you!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The three newly added test fixtures contain the same avoidable spelling errors in their comments, which should be corrected.

3 open issues
What changed in this PR

This pull request registers the ro-alice, ro-miro, and samp namespaces in the PDS4 namespace registry and Information Model configuration, with integration fixtures validating LDD generation and label validation.

Changes:

  • Added registry metadata and configuration for two Rosetta mission namespaces and the Sample discipline namespace.
  • Added ingest LDD fixtures and passing label examples for each namespace.
  • Added three Cucumber validation scenarios for namespace generation and label validation.
File Description
model-ontology/​src/​ontology/​Data/​config.properties Adds Information Model configuration blocks for the ro-alice, ro-miro, and samp namespaces.
model-lddtool/​src/​test/​resources/​features/​validate.feature Adds validation scenarios covering LDD generation and label validation for all three namespaces.
model-lddtool/​src/​test/​resources/​data/​update_version/​github1109/​PDS4_PARTICLE_IngestLDD_samp.xml Provides the samp namespace ingest LDD test fixture.
model-lddtool/​src/​test/​resources/​data/​update_version/​github1109/​namespace_samp_Pass_261112.xml Provides a passing product-label fixture using the samp namespace.
model-lddtool/​src/​test/​resources/​data/​update_version/​github1098/​PDS4_PARTICLE_IngestLDD_ro-miro.xml Provides the ro-miro namespace ingest LDD test fixture.
model-lddtool/​src/​test/​resources/​data/​update_version/​github1098/​namespace_ro-miro_Pass_261112.xml Provides a passing product-label fixture using the ro-miro namespace.
model-lddtool/​src/​test/​resources/​data/​update_version/​github1097/​PDS4_PARTICLE_IngestLDD_ro-alice.xml Provides the ro-alice namespace ingest LDD test fixture.
model-lddtool/​src/​test/​resources/​data/​update_version/​github1097/​namespace_ro-alice_Pass_261112.xml Provides a passing product-label fixture using the ro-alice namespace.
docs/​namespace-registry/​pds-namespace-registry.csv Registers the three new namespaces and updates the registry date.

Review effort: Lite

…st comment'

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings November 13, 2026 23:31
jshughes and others added 2 commits November 13, 2026 18:32
…st comment'

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…st comment'

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Two active nit findings remain because newly added test fixtures contain the misspellings “purposed” and “editted,” which should be corrected to “purpose” and “edited.”

No open issues 🎉

3 resolved since last review

Review effort: Lite

Copilot AI lite review requested due to automatic review settings November 13, 2026 23:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Repository evidence cannot establish the externally governed NASA-PDS/ESA namespace hosting, URN authority, steward mappings, or downstream compatibility of the new hyphenated IDs and ads code.

No open issues 🎉

Review effort: Lite

@jshughes jshughes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three namespaces have been successfully added to the namespace registry and the config.properties file.

@c-suh
c-suh merged commit 10b25eb into main Nov 15, 2026
4 checks passed
@c-suh
c-suh deleted the feature/new-namespace-issue1097-1098-1109 branch November 15, 2026 18:23
@c-suh

c-suh commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@jshughes thank you for the fixes and approval! I merged these changes but neglected to confirm the four bullet points with you from the "No precedent in the repo" section in the description. Are these good as is, or are there any changes required? In particular, I'm concerned with the first and last bullet point; the middle two overlap with #1108.

@c-suh
c-suh restored the feature/new-namespace-issue1097-1098-1109 branch November 15, 2026 18:34
@c-suh

c-suh commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@jshughes I just saw the email thread regarding the first bullet point. Yes, I will make those hyphen-to-underscore changes. Do let me know about the other points as well! Thank you.

@c-suh
c-suh deleted the feature/new-namespace-issue1097-1098-1109 branch November 15, 2026 18:50
@c-suh c-suh mentioned this pull request Nov 15, 2026
3 of 25 tasks
@jshughes

Copy link
Copy Markdown
Contributor

@c-suh > Are these good as is, or are there any changes required?

These are good for now. You are right, there is a overlap with #1108.

However, this issue will take awhile to resolve since it is not clear how formally we need to manage stewards. It is still in my queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[namespace-registry] add new namespace samp [namespace-registry] add new namespace ro_miro [namespace-registry] add new namespace ro_alice

3 participants