Repository navigation
Add new namespaces ro-alice, ro-miro, samp - #1111
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@jshughes please review this PR for these 3 namespace requests. Also note the bottom section of the description titled "No precedent in the repo". Thank you! |
There was a problem hiding this comment.
🟡 Changes recommended
The three newly added test fixtures contain the same avoidable spelling errors in their comments, which should be corrected.
3 open issues
What changed in this PR
This pull request registers the ro-alice, ro-miro, and samp namespaces in the PDS4 namespace registry and Information Model configuration, with integration fixtures validating LDD generation and label validation.
Changes:
- Added registry metadata and configuration for two Rosetta mission namespaces and the Sample discipline namespace.
- Added ingest LDD fixtures and passing label examples for each namespace.
- Added three Cucumber validation scenarios for namespace generation and label validation.
| File | Description |
|---|---|
| model-ontology/src/ontology/Data/config.properties | Adds Information Model configuration blocks for the ro-alice, ro-miro, and samp namespaces. |
| model-lddtool/src/test/resources/features/validate.feature | Adds validation scenarios covering LDD generation and label validation for all three namespaces. |
| model-lddtool/src/test/resources/data/update_version/github1109/PDS4_PARTICLE_IngestLDD_samp.xml | Provides the samp namespace ingest LDD test fixture. |
| model-lddtool/src/test/resources/data/update_version/github1109/namespace_samp_Pass_261112.xml | Provides a passing product-label fixture using the samp namespace. |
| model-lddtool/src/test/resources/data/update_version/github1098/PDS4_PARTICLE_IngestLDD_ro-miro.xml | Provides the ro-miro namespace ingest LDD test fixture. |
| model-lddtool/src/test/resources/data/update_version/github1098/namespace_ro-miro_Pass_261112.xml | Provides a passing product-label fixture using the ro-miro namespace. |
| model-lddtool/src/test/resources/data/update_version/github1097/PDS4_PARTICLE_IngestLDD_ro-alice.xml | Provides the ro-alice namespace ingest LDD test fixture. |
| model-lddtool/src/test/resources/data/update_version/github1097/namespace_ro-alice_Pass_261112.xml | Provides a passing product-label fixture using the ro-alice namespace. |
| docs/namespace-registry/pds-namespace-registry.csv | Registers the three new namespaces and updates the registry date. |
Review effort: Lite
…st comment' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…st comment' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…st comment' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
There was a problem hiding this comment.
🔵 Needs a closer look
Two active nit findings remain because newly added test fixtures contain the misspellings “purposed” and “editted,” which should be corrected to “purpose” and “edited.”
No open issues 🎉
3 resolved since last review
Review effort: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
Repository evidence cannot establish the externally governed NASA-PDS/ESA namespace hosting, URN authority, steward mappings, or downstream compatibility of the new hyphenated IDs and ads code.
No open issues 🎉
Review effort: Lite
jshughes
left a comment
There was a problem hiding this comment.
The three namespaces have been successfully added to the namespace registry and the config.properties file.
|
@jshughes thank you for the fixes and approval! I merged these changes but neglected to confirm the four bullet points with you from the "No precedent in the repo" section in the description. Are these good as is, or are there any changes required? In particular, I'm concerned with the first and last bullet point; the middle two overlap with #1108. |
|
@jshughes I just saw the email thread regarding the first bullet point. Yes, I will make those hyphen-to-underscore changes. Do let me know about the other points as well! Thank you. |




Resolves #1097
Resolves #1098
Resolves #1109
Adds three namespaces to the registry and the IM config:
ro-alice(Rosetta Alice Instrument Dictionary, Mission), requested in [ldd-request] Create new LDD "ro_alice" operations#1618ro-miro(Rosetta MIRO Dictionary, Mission), requested in [ldd-request] Create new LDD "ro_miro" operations#1619samp(Sample, Discipline), requested in [ldd-request] Create new LDD "samp" operations#1635Changes
docs/namespace-registry/pds-namespace-registry.csv: three new rows,Last Updatebumped to 2026-11-12model-ontology/src/ontology/Data/config.properties: three newlSchemaFileDefnblocks, header timestamp bumpedmodel-lddtool/src/test/resources/data/update_version/github1097|github1098|github1109/: Ingest LDD and passing label for IM 1.27.0.0 / 1R00model-lddtool/src/test/resources/features/validate.feature: three new rows ([namespace-registry] add new namespace ro_alice #1097, [namespace-registry] add new namespace ro_miro #1098, [namespace-registry] add new namespace samp #1109)Testing
mvn clean test: 91 tests, 0 failures, BUILD SUCCESS. Each new scenario (github1097,github1098,github1109) generates its LDD and validates the label with 0 errors and 0 warnings.The registry PDF/XLSX are not edited here; CI regenerates them from the CSV after merge.
CHANGELOG.mdis left to the release tooling.Prior work
samp#1110 (closed, unmerged; same skill dry run). That PR usedesaas a steward code, which does not exist; this one usespsa.No precedent in the repo
ro-alice,ro-miro): no existing namespace has one. Done: used as-is. Build generatedPDS4_RO-ALICE_1R00_1010.xsd/.schandPDS4_RO-MIRO_1R00_1010.xsd/.schand validation passes. Reviewer: confirm the hyphen is acceptable in published schema file names and downstream tooling.stewardArrcodeads(Astromaterials Data System) insamp(geo,psa,ads). Done: added as listed in the operations issue. Reviewer: confirm the code name.stewardArrcombinationspds,psa(ro-alice) andsbn,psa(ro-miro). Done: each code exists, butpdsappears only insidepds,img,opsand these pairings are new. The operations issues give free text ("NASA PDS (US Instrument Team) ... in cooperation with ESA/PSA", "SBN (US Instrument Team), in cooperation with ESA PSA"), so the mapping was chosen by the requester of this PR. Reviewer: confirm.pds.nasa.gov/pds4/,urn:nasa:pds:,PDS4,0001_NASA_PDS_1, label URIhttp://pds.nasa.gov/pds4/mission/<ns>/v1. Existing ESA mission namespaces usepsa.esa.int/urn:esa:psa:. Reviewer: confirm NASA hosting is intended.🤖 Generated with Claude Code