Remove pytables as a dependency - #340
Merged
Merged
Conversation
… the alphapept protein group reader but induces a lot of complexity and dependency conflicts, including numpy
…a single function
Collaborator
Author
|
Full test matrix passed |
mschwoer
approved these changes
Aug 27, 2025
mschwoer
reviewed
Aug 27, 2025
mschwoer
approved these changes
Aug 27, 2025
mschwoer
left a comment
mschwoer
left a comment
Contributor
There was a problem hiding this comment.
*hits approve button harder*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytablesis only required by a single utility (hdf file reader ofAlphapeptPGReader), but it significantly increases the complexity of the installation + testing functionalities.If users try to import
hdffiles, they get a very clear error message from pandasTherefore, this PR removes pytables as dependency of alphabase, and skips the respective integration tests in an environment in which the package is not installed. This only affects alphapept
.hdfoutput files. A note was added to the alphapept reader that makes users aware that they need to install thetablespackage in order to be able to read.hdffiles.