Add parquet support in Base PSMReader class default _load_file() method. - #328
Merged
Conversation
mschwoer
approved these changes
Aug 1, 2025
| sep = _get_delimiter(filename) | ||
| return pd.read_csv(filename, sep=sep, keep_default_na=False) | ||
|
|
||
| if filename.endswith(".parquet"): |
Contributor
There was a problem hiding this comment.
should we use pathlib.Path.extension here?
boopthesnoot
force-pushed
the
parquet_loader
branch
from
August 1, 2025 15:45
66ea9e8 to
21d9818
Compare
boopthesnoot
force-pushed
the
parquet_loader
branch
from
August 1, 2025 15:59
21d9818 to
645c1fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer DIANN versions return a .parquet file instead of a .tsv report, which should be covered by the default file reader.