Skip to content

Raise an error when attempting to close stdio or stderr #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-torrance wants to merge 1 commit into
base: development
Choose a base branch
from
+7 −0
Open

Raise an error when attempting to close stdio or stderr #4480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions M2/Macaulay2/d/stdio.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,7 @@ export closeListener(o:file):(errmsg or null) := (
null());

export closeIn(o:file):(errmsg or null) := (
if o == stdIO then return errmsg("can't close stdio");
stat := 0;
if o.infd == NOFD then return errmsg("close: file not open");
if o == stdIO then return null(); -- silently refuse to close stdIO
Expand All @@ -538,6 +539,8 @@ export closeIn(o:file):(errmsg or null) := (
null());

export closeOut(o:file):(errmsg or null) := (
if o == stdIO then return errmsg("can't close stdio");
if o == stdError then return errmsg("can't close stderr");
stat := 0;
if o.outfd == NOFD then return errmsg("close: file not open");
haderror := false;
Expand Down
4 changes: 4 additions & 0 deletions M2/Macaulay2/tests/normal/files.m2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,7 @@ assert(baseFilename "foo////" == "foo")
assert(baseFilename "" == "")
assert(baseFilename "/" == "/")
assert(baseFilename "////" == "/")

-- issue #4392
assert try stdio << close then false else true
assert try stderr << close then false else true