Raise an error when attempting to close stdio or stderr - #4480
Open
d-torrance wants to merge 1 commit into
Open
Conversation
stdio supports both input and output, so we check in both closeIn and closeOut stderr only supports output, so we only check in closeOut (stderr << closeIn already raises an error since it's not open for input)
MichaelABurr
approved these changes
Jul 19, 2026
MichaelABurr
left a comment
Member
There was a problem hiding this comment.
Simple, and looks OK to me. I don't expect this code to be encountered frequently, so I don't expect a performance hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdiosupports both input and output, so we check in bothcloseInandcloseOutstderronly supports output, so we only check incloseOut(stderr << closeInalready raises an error since it's not open for input)Closes: #4392
No AI used!
Before
After