fix(test): repair fr007 health-csv test for StatusJson::log_location - #733
Conversation
e2ceacd (#731) added log_location to StatusJson and updated seven of the eight fr007 test literals but missed tests/fr007_health_pool_status_csv.rs, which omits the required field (E0063) and was never rustfmt-formatted. Main's own ci-gate run on e2ceacd fails; every PR against it inherits the break. - Add `log_location: None` to the StatusJson literal. - cargo fmt --all reflow of the file. Verified: cargo fmt --all -- --check (0 diffs) and cargo check --workspace --all-targets both pass.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (31)
📝 WalkthroughSummaryThis PR fixes the FR-007 health CSV test after The PR also removes a stale test that rejected the supported Must FixNo blocking issues identified. Should FixNone. ConsiderWorkspace formatting and Approve / Request ChangesApprove. WalkthroughThe pull request reformats fixtures, assertions, command construction, and rendering expressions in the health, pool, and status CSV integration test. Test behavior and coverage remain unchanged. ChangesCSV test formatting
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized test-only change restores the health CSV test build and formatting checks without changing product behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:S
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewIncremental change since previous review (commit The removed test asserted that No new inline findings; the deletion is a clean, complete removal of the entire test function (doc comment + body), with the next test's doc comment ( Files Reviewed (1 file)
Previous Review Summaries (2 snapshots, latest commit 17497a1)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 17497a1)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous review (commit 71a3973)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by laguna-s-2.1:free · Input: 167.6K · Output: 5.7K · Cached: 51.7K |
Quality Gate Report✅ Unit Tests: PASSED |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Quality Gate Report✅ Unit Tests: PASSED |
fr007_health_csv_rejects_watch asserted that `sharecli health --csv --watch 1` must fail fast (a misreading of AC-007.82), but AC-007.89 defines health --csv --watch as a supported multi-frame watch mode and both tests/fr007_operator_csv_watch.rs and the envelope-parity suite exercise it as working behavior; the CLI implements the watch loop. The stale test spawned the infinite watch process and blocked on output() forever, hanging the fr007 test binary and stalling the Coverage lane's cargo llvm-cov run (reproduced locally: the suite hung on this test with and without instrumentation; CI coverage ran 2h45m without completing). Remove the test; the AC-007.89 watch envelope behavior remains covered by fr007_operator_csv_watch.rs / fr007_operator_envelope_parity_suite.rs.
|
Quality Gate Report✅ Unit Tests: PASSED |
|
Tick the box to add this pull request to the merge queue (same as
|
What
Fixes the ci-gate/coverage break introduced by
e2ceacdd(#731). Main's own ci-gate run on #731 fails, and every PR against current main inherits it.Three defects in
tests/fr007_health_pool_status_csv.rs:StatusJson { ... }literal omits thelog_locationfield. feat(sharecli): land fr007 health-pool-status-csv + agent-call admission kernel #731 addedlog_locationtoStatusJsonand updated seven of the eight fr007 test literals, but missed this one.fr007_health_csv_rejects_watchasserted thathealth --csv --watch 1must fail fast (a misreading of AC-007.82), but AC-007.89 defines health/pool/status--csv --watchas supported multi-frame watch modes (exercised byfr007_operator_csv_watch.rsand the envelope-parity suite, which the CLI implements). The stale test spawned the infinite watch process and blocked onoutput()forever — hanging the test binary and stalling the Coverage lane'scargo llvm-cov(CI ran 2h45m without completing; reproduced locally with and without instrumentation).Changes
log_location: Noneto theStatusJsonliteral.cargo fmt --allreflow of the file.fr007_health_csv_rejects_watchtest (AC-007.89 watch envelope behavior remains covered by the sibling suites).Validation
cargo fmt --all -- --check: 0 diffs (workspace-wide).cargo check --workspace --all-targets: passes.cargo test --locked --all-features --test fr007_health_pool_status_csv: completes in ~21s (was: infinite hang).FR reference: FR-007 (health pool / status JSON), FR-003 (hard gates)