ci(sharecli): re-trigger checks after stuck coverage runner - #736
Conversation
e2ceacd (#731) added log_location to StatusJson and updated seven of the eight fr007 test literals but missed tests/fr007_health_pool_status_csv.rs, which omits the required field (E0063) and was never rustfmt-formatted. Main's own ci-gate run on e2ceacd fails; every PR against it inherits the break. - Add `log_location: None` to the StatusJson literal. - cargo fmt --all reflow of the file. Verified: cargo fmt --all -- --check (0 diffs) and cargo check --workspace --all-targets both pass.
fr007_health_csv_rejects_watch asserted that `sharecli health --csv --watch 1` must fail fast (a misreading of AC-007.82), but AC-007.89 defines health --csv --watch as a supported multi-frame watch mode and both tests/fr007_operator_csv_watch.rs and the envelope-parity suite exercise it as working behavior; the CLI implements the watch loop. The stale test spawned the infinite watch process and blocked on output() forever, hanging the fr007 test binary and stalling the Coverage lane's cargo llvm-cov run (reproduced locally: the suite hung on this test with and without instrumentation; CI coverage ran 2h45m without completing). Remove the test; the AC-007.89 watch envelope behavior remains covered by fr007_operator_csv_watch.rs / fr007_operator_envelope_parity_suite.rs.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:S
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (27)
🧰 Additional context used📓 Path-based instructions (3)**/*📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.rs📄 CodeRabbit inference engine (CLAUDE.md)
Files:
**/*.{rs,toml}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (7)
📝 WalkthroughSummaryThe PR updates FR-007 health tests. It sets Must FixNone identified. Should FixNone identified. ConsiderConfirm that the CI re-trigger configuration change is included in the final diff. The provided change summary only shows updates to Approve / Request ChangesApprove, provided the CI re-trigger change is present in the final diff. WalkthroughThe PR updates health and pool CSV test fixtures and assertions. It retains CSV success and pool incompatibility coverage, removes the health ChangesHealth and pool CSV tests
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized test change has no actionable merge-blocking risk; it is merge-ready after the normal Rust validation checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Tick the box to add this pull request to the merge queue (same as
|
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by step-3.7-flash · Input: 99.8K · Output: 10.7K · Cached: 1.1M |
Quality Gate Report✅ Unit Tests: PASSED |
User description
Forward-port of single-commit
fix/fr007-health-csv-build-fix(71a3973). CI re-trigger command after the FR-007 coverage runner got stuck. Low-risk YAML-only change.CodeAnt-AI Description
Repair FR-007 CSV tests and stop coverage runs from hanging
What Changed
health --csv --watch, allowing the supported watch behavior to remain covered by the correct testsImpact
✅ Coverage checks complete without hanging✅ Health CSV watch behavior is tested correctly✅ FR-007 tests pass with current status data💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.