Update ir_mex_build to build penalty_mex file - #32
Conversation
…ld. Edit mex command for penalty_mex.
Co-authored-by: Jeff Fessler <JeffFessler@users.noreply.github.com>
Co-authored-by: Jeff Fessler <JeffFessler@users.noreply.github.com>
Co-authored-by: Jeff Fessler <JeffFessler@users.noreply.github.com>
Co-authored-by: Jeff Fessler <JeffFessler@users.noreply.github.com>
| addpath([irtdir 'mex/local']) % must precede "mex/v7" | ||
| addpath([irtdir 'mex/v7']); | ||
|
|
||
| disp('NOTE: Previous irt versions expected MEX files in "mex/v7".') |
There was a problem hiding this comment.
Added a comment about the mex/v7 directory. Let me know if you prefer a different message!
| disp(sprintf('The directory "%s" does not exist. Creating it now.', [irtdir 'mex/local'])) | ||
| mkdir([irtdir 'mex/local']); | ||
| end | ||
|
|
There was a problem hiding this comment.
Automatically create the mex/local directory if it doesn't exist
|
Thanks for the review! |
|
Thanks for the updates and I appreciate you testing them. I've made a couple (hopefully final) suggestions based on #33. |
Co-authored-by: Jeff Fessler <JeffFessler@users.noreply.github.com>
Co-authored-by: Jeff Fessler <JeffFessler@users.noreply.github.com>
|
Thanks for the additional suggestions. I re-tested in my environment and they look good on my end. I can successfully compile |
Description of changes:
mex/to MATLAB path insetup.mto ensure mex source files are availableirt_mex_maketoir_mex_build.mso it is run as part of standard buildirt_mex_makeso the script runs when called fromir_mex_buildNote: this means there would be an error when running
irt_mex_makefrom themex/srcdirectory, so there might be a more elegant solutionmexbuild command forpenalty_mexto reflect current directory structure. Note that it no longer saves to themex/v7folder.