Skip to content

Revert "hermes-agent: deprecate" #297271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SMillerDev wants to merge 2 commits into from
+8 −5
Closed

Revert "hermes-agent: deprecate" #297271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1fcf97
Revert "hermes-agent: deprecate"
SMillerDev Aug 5, 2026
ccf5be1
hermes-agent: add patch for socksio
daeho-ro Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Formula/h/hermes-agent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ class HermesAgent < Formula
sha256 cellar: :any, x86_64_linux: "62dad23f60f0a785378ef2ea188255a724633e437cd5305ff667643a10a036f2"
end

# Support for brew was removed in https://github.com/NousResearch/hermes-agent/pull/68217
# Formula can not be updated
deprecate! date: "2026-08-03", because: "Upstream does not suppoort brew anymore"
disable! date: "2027-02-03", because: :unmaintained

depends_on "pkgconf" => :build
depends_on "rust" => :build
depends_on "certifi" => :no_linkage
Expand Down Expand Up @@ -239,6 +234,14 @@ class HermesAgent < Formula
type :backport
resolves "https://github.com/sethmlarson/socksio/pull/61"
end

# Workaround for flit-core 4+
patch do
url "https://github.com/sethmlarson/socksio/commit/504f7e51682b9526d3ecc7ea893338af1fedfb2d.patch?full_index=1"
sha256 "b0c327c4e8fa722669dc372263d735f429015587e02935e2e8cb2b22028c0bfb"
type :unofficial
resolves "https://github.com/sethmlarson/socksio/pull/66"
end
end
Comment on lines +238 to 245

@SMillerDev SMillerDev Aug 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just use the other PR or wait until it's merged

@MikeMcQuaid MikeMcQuaid Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMillerDev why not just use this one?

@SMillerDev SMillerDev Aug 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is just from a PR that's failing the CI at socksio. #297327 is much smaller.

@MikeMcQuaid MikeMcQuaid Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, yeh, it's green let's ship it for now.


resource "starlette" do
Expand Down
Loading