Skip to content

Revert "hermes-agent: deprecate" - #297271

Open
SMillerDev wants to merge 2 commits into
mainfrom
revert-296811-bump-hermes-agent-2026.8.3
Open

Revert "hermes-agent: deprecate"#297271
SMillerDev wants to merge 2 commits into
mainfrom
revert-296811-bump-hermes-agent-2026.8.3

Conversation

@SMillerDev

@SMillerDev SMillerDev commented Aug 5, 2026

Copy link
Copy Markdown
Member
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

@github-actions github-actions Bot added autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Aug 5, 2026
@dot-agi dot-agi mentioned this pull request Aug 5, 2026
Open
7 tasks
dot-agi added a commit to dot-agi/homebrew-core that referenced this pull request Aug 6, 2026
@dot-agi @SMillerDev
hermes-agent: undeprecate, fix socksio build
4e086ad 
Revert the deprecation (Homebrew#296811): the formula still builds from
upstream source with HERMES_NIX_BUILD=1, and the 2026.8.3 bottles
landed after it was merged. Original revert by Sean Molenaar
(Homebrew#297271).

Fix the build under flit_core 4.0.1 (released 2026-08-04), which
removed the legacy [tool.flit.metadata] table: socksio 1.0.0's
patched build requirement is unbounded (flit_core >=2), so cap it
below 4 while building that resource. socksio upstream has had no
release since 1.0.0, so there is no upstream commit to backport.

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
@dot-agi

dot-agi commented Aug 6, 2026

Copy link
Copy Markdown

Hey @SMillerDev I saw the CI breaking so I made a PR that picks up on your revert and resolves the socksio breakage. The builds are passing in my PR. I appreciate your work as I was the one who submitted the formula for the hermes-agent installation.

@MikeMcQuaid can you please take a look at #297327?

@p-linnane

p-linnane commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Why do we want to do this? Did something change upstream?

@dot-agi

dot-agi commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Why do we want to do this? Did something change upstream?

The upstream repo explicitly removed support for Homebrew and pip/PyPI wheel. I am unsure why this step was taken. This comment from @iMichka acknowledges the change; #296811 deprecates it altogether.

When I created the formula for hermes-agent, there was no Homebrew-specific code, and the installation was at parity with upstream. I will continue to advocate for maintaining this formula given its download history and ease of use with brew.

This PR is supposed to revert the deprecation, but it fails the CI against which I created the new PR with the fix (which now stands closed).

@p-linnane
p-linnane requested a review from iMichka August 6, 2026 06:03
@MikeMcQuaid

MikeMcQuaid commented Aug 6, 2026

Copy link
Copy Markdown
Member

Why do we want to do this? Did something change upstream?

We discussed in Slack. The formula still builds and we document we don't deprecate things just because upstream says so: https://docs.brew.sh/Working-with-Homebrew-as-an-Upstream-Project

@daeho-ro
daeho-ro force-pushed the revert-296811-bump-hermes-agent-2026.8.3 branch from c18f726 to ed2a9d1 Compare August 6, 2026 13:24
@daeho-ro
daeho-ro force-pushed the revert-296811-bump-hermes-agent-2026.8.3 branch from ed2a9d1 to ccf5be1 Compare August 6, 2026 13:27
SMillerDev
SMillerDev commented Aug 6, 2026
View reviewed changes
Comment thread Formula/h/hermes-agent.rb
Comment on lines +238 to 245
# Workaround for flit-core 4+
patch do
url "https://github.com/sethmlarson/socksio/commit/504f7e51682b9526d3ecc7ea893338af1fedfb2d.patch?full_index=1"
sha256 "b0c327c4e8fa722669dc372263d735f429015587e02935e2e8cb2b22028c0bfb"
type :unofficial
resolves "https://github.com/sethmlarson/socksio/pull/66"
end
end

@SMillerDev SMillerDev Aug 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just use the other PR or wait until it's merged

@MikeMcQuaid MikeMcQuaid Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMillerDev why not just use this one?

@SMillerDev SMillerDev Aug 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is just from a PR that's failing the CI at socksio. #297327 is much smaller.

@MikeMcQuaid MikeMcQuaid Aug 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, yeh, it's green let's ship it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes
@iMichka iMichka Awaiting requested review from iMichka

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SMillerDev @dot-agi @p-linnane @MikeMcQuaid @daeho-ro