Skip to content

[CRASHFIX] Fix crash when reopening ease graph previews in editors #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiryvajiravuth wants to merge 1 commit into
base: preview/public-playtest
Choose a base branch
from
+15 −1
Open

[CRASHFIX] Fix crash when reopening ease graph previews in editors #7907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion source/funkin/play/event/SongEventHelper.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package funkin.play.event;
import flixel.tweens.FlxEase;
import openfl.display.BitmapData;
import flixel.FlxSprite;
import funkin.assets.FunkinBitmapFrontend;

class SongEventHelper
{
Expand Down Expand Up @@ -204,7 +205,20 @@ class SongEventHelper

public static function getOrCreateEaseDotSprites(key:String, frameCount:Int = 30, dotRadius:Int = 3, dotWidth:Int = 16):Array<FlxSprite>
{
if (easeDotCache.exists(key)) return easeDotCache.get(key);
if (easeDotCache.exists(key))
{
var valid:Bool = true;
for (spr in easeDotCache.get(key))
{
if (spr == null || !FunkinBitmapFrontend.instance.isValid(spr.graphic))
{
valid = false;
break;
}
}
if (valid) return easeDotCache.get(key);
easeDotCache.remove(key);
}
var baseBd:BitmapData = getEaseBitmap(key);
if (baseBd == null) return null;
var easeFunc:Dynamic = resolveEaseFuncForKey(key);
Expand Down
Loading