[CRASHFIX] Fix crash when reopening ease graph previews in editors - #7907
Open
kiryvajiravuth wants to merge 1 commit into
Open
[CRASHFIX] Fix crash when reopening ease graph previews in editors#7907kiryvajiravuth wants to merge 1 commit into
kiryvajiravuth wants to merge 1 commit into
Conversation
github-actions
Bot
added
size: medium
kiryvajiravuth
force-pushed
the
fix-crash-fr
branch
from
August 10, 2026 07:23
799bc2a to
0c72016
Compare
github-actions
Bot
added
the
size: medium
NotHyper-474
added
type: major bug
|
not a reviewer but! i checked these and they work too!! |
Hundrec
changed the title
Hundrec
self-requested a review
August 10, 2026 21:03
NotHyper-474
added
the
topic: camera editor
kiryvajiravuth
force-pushed
the
fix-crash-fr
branch
from
August 11, 2026 22:35
0c72016 to
feae1ef
Compare
kiryvajiravuth
force-pushed
the
fix-crash-fr
branch
from
August 14, 2026 02:16
feae1ef to
9d918e5
Compare
EliteMasterEric
self-requested a review
August 14, 2026 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
closes #7882
Description
Cause:
The ease previews cache their dot images (
easeDotCacheinSongEventHelper) so they only get generated once. The problem: when you exit an editor the game purges its cached graphics , but the ease preview cache was never cleared or told about it.So on the next open the editor pulled sprites out of the cache that were already destroyed tried to draw them and crashed with a Null Object Reference.
Fix:
getOrCreateEaseDotSprites()now checks that each cached sprite's graphic is still alive before reusing it. If the game purged them during the previous editor exit, the cache entry is dropped and the sprites get rebuilt fresh instead of crashing.A one-function change in SongEventHelper.hx.
Screenshots/Videos
before (chart editor)
before-1.mp4
before (camera editor)
before-2.mp4
after (chart editor)
after-1.mp4
after (camera editor)
after-2.mp4