-
Notifications
You must be signed in to change notification settings - Fork 361
ctsm5.4.055: CDEPS/CMEPS updates for cplhist and 1850 ndep from DATM #4180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ekluzek
wants to merge
20
commits into
ESCOMP:master
Choose a base branch
from
ekluzek:cdeps_updates_for_cplhist
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3ab9b52
Update to cdeps version including important CPLHIST mode changes
ekluzek 77f6993
Turn on CLM_NDEP_FROM_CPL for CPLHIST and point to a different CPLHIS…
ekluzek 0ed1c8f
Merge tag 'ctsm5.4.052' into cdeps_updates_for_cplhist
ekluzek 24ce1f6
Remove cplhist testmod because we'll just use the default cplhist for…
ekluzek dcbab7f
Update cdeps with more DATM checking in place
ekluzek 01090dc
Actually remove the cplhist testmod
ekluzek 69a95c7
OK, the Clm50 spinup compset doesn't have Crop on, so change it back
ekluzek 325e95b
Another small update to cdeps
ekluzek 5257fe2
Use CO2 from DATM for 1850 CPLHIST mode, and use ndep from DATM for 1850
ekluzek 864560e
Update submodules to latest
ekluzek 9f9df56
Update cdeps to latest
ekluzek 4c58c6e
Merge tag 'ctsm5.4.053' into cdeps_updates_for_cplhist
ekluzek 74095cb
The updated cmeps required share to be updated
ekluzek f5d3c5e
Update cdeps and cmeps based on code review
ekluzek c715fdf
Update cdeps to fix a XML syntax error
ekluzek f2e2fcc
Bring in a cime PR to be able to handle the difference between CESM a…
ekluzek d710764
Update cdeps with latest changes in responce to code review
ekluzek 6e2110a
Mark black commits
ekluzek 8ae0fc2
Update cime again
ekluzek a862526
Merge tag 'ctsm5.4.054' into cdeps_updates_for_cplhist
ekluzek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -273,6 +273,7 @@ Caveats: | |
| <value compset="_BGC%BDRD" >diagnostic</value> | ||
| <value compset="_BGC%BPRP" >prognostic</value> | ||
| <value compset="HIST.*_DATM" >diagnostic</value> | ||
| <value compset="1850.*_DATM%CPLHIST" >diagnostic</value> | ||
| <value compset="SSP.*_DATM" >diagnostic</value> | ||
| </values> | ||
| <group>run_component_ctsm</group> | ||
|
|
@@ -307,6 +308,8 @@ Caveats: | |
| <default_value>FALSE</default_value> | ||
| <values> | ||
| <value compset="_CAM" >TRUE</value> | ||
| <value compset="_DATM%CPLHIST" >TRUE</value> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmmm. Should this just be for 1850 and with CLM60 or all the time? We assume CPLHIST data in CDEPS come from recent cases likely run with CLM60, so this is probably right... |
||
| <value compset="1850_.*CLM60" >TRUE</value> | ||
| </values> | ||
| <group>run_component_ctsm</group> | ||
| <file>env_run.xml</file> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
cime_config/testdefs/testmods_dirs/clm/cplhist/include_user_mods
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
cime_config/testdefs/testmods_dirs/clm/cplhist/shell_commands
This file was deleted.
Oops, something went wrong.
Submodule cdeps
updated
15 files
| +2 −2 | datm/atm_comp_nuopc.F90 | |
| +151 −32 | datm/cime_config/buildnml | |
| +12 −2 | datm/cime_config/config_component.xml | |
| +44 −3 | datm/cime_config/stream_definition_datm.xml | |
| +0 −5 | datm/cime_config/testdefs/testmods_dirs/datm/cplhist/shell_commands | |
| +2 −1 | dglc/glc_comp_nuopc.F90 | |
| +2 −2 | dice/cime_config/buildnml | |
| +2 −2 | dice/ice_comp_nuopc.F90 | |
| +2 −2 | dlnd/lnd_comp_nuopc.F90 | |
| +2 −2 | docn/cime_config/buildnml | |
| +2 −2 | docn/ocn_comp_nuopc.F90 | |
| +2 −2 | drof/rof_comp_nuopc.F90 | |
| +1 −3 | dshr/dshr_mod.F90 | |
| +2 −2 | dwav/wav_comp_nuopc.F90 | |
| +14 −3 | streams/dshr_strdata_mod.F90 |
Submodule cmeps
updated
61 files
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CO2 settings need to be consistent in CLM, DATM and CMEPS. There should be some error checking to check on that. There are various problems that happen if they aren't.