Skip to content

ctsm5.4.055: CDEPS/CMEPS updates for cplhist and 1850 ndep from DATM - #4180

Open
ekluzek wants to merge 19 commits into
ESCOMP:masterfrom
ekluzek:cdeps_updates_for_cplhist
Open

ctsm5.4.055: CDEPS/CMEPS updates for cplhist and 1850 ndep from DATM#4180
ekluzek wants to merge 19 commits into
ESCOMP:masterfrom
ekluzek:cdeps_updates_for_cplhist

Conversation

@ekluzek

@ekluzek ekluzek commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Update CDEPS with changes for CPLHIST mode. Turn on CLM_NDEP_FROM_CPL for CPLHIST mode. change cplhist test mod to use a different case. This should have everything needed to start CPLHIST spinups out of the box.

Also for 1850 with CLM60 use ndep from DATM

Specific notes

Contributors other than yourself, if any:

CTSM issues resolved or otherwise addressed, if any:

If answers are expected to change, describe (delete this line otherwise): Yes, just for CPLHIST mode

Any user interface changes (namelist or namelist defaults changes)?

Testing planned or performed, if any:

  • aux_clm Derecho
  • aux_clm Izumi
  • aux_cdeps Derecho
  • cmeps testing of some sort Derecho

Requirements before merge:

  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s):
  • This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?:
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe:
  • This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?:

@ekluzek ekluzek self-assigned this Aug 19, 2026
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science labels Aug 19, 2026
@ekluzek ekluzek added the usability Improve or clarify user-facing options label Aug 19, 2026
@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Aug 19, 2026
@ekluzek ekluzek added the non-b4b Changes answers (incl. adding tests) label Aug 19, 2026
@ekluzek ekluzek moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Aug 19, 2026
@ekluzek ekluzek changed the title CDEPS updates for cplhist ctsm5.4.054: CDEPS updates for cplhist Aug 19, 2026
@ekluzek
ekluzek marked this pull request as draft August 19, 2026 16:13
@ekluzek

ekluzek commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

aux_cdeps testing is looking as expected.

aux_clm testing showed problems with these:

ERI_D_Ld9.f10_f10_mg37.I1850Clm60Bgc.derecho_gnu.clm-default    ( RUN)
ERI_D_Ld9.f10_f10_mg37.I1850Clm60Bgc.derecho_gnu.clm-default--clm-matrixcnOn    ( RUN)
ERI_D_Ld9.f10_f10_mg37.I1850Clm60BgcCrujra.derecho_gnu.clm-default      ( RUN)
ERP_D_P64x2_Ld3.f10_f10_mg37.I1850Clm60BgcCrop.derecho_gnu.clm-mimics   ( RUN)
SETPARAMFILE_Ld5.f10_f10_mg37.I1850Clm60BgcCrujra.derecho_gnu.clm-default       ( RUN)
SMS_D.1x1_brazil.I1850Clm60BgcCropCrujraRsGs.derecho_gnu.clm-mimics_matrixcn    ( RUN)
SMS_D_Ld1.ne30pg3_t232.I1850Clm50BgcSpinup.derecho_intel.clm-default--clm-matrixcnOn    (SETUP)
SMS_D_Ld5_PS.f09_f09_mt232.I1850Clm60BgcCrop.derecho_gnu.clm-f09_ObscureStreamOpts      ( RUN)
SMS_Ld5.f10_f10_mg37.I1850Clm60BgcCrop.derecho_gnu.clm-till--clm-remove_residues        ( RUN)
SMS_Lm1.f10_f10_mg37.I1850Clm60BgcCropCmip6waccm.derecho_gnu.clm-basic  ( RUN)

which has to do with the new 1850 CO2 file in CDEPS

@ekluzek ekluzek changed the title ctsm5.4.054: CDEPS updates for cplhist ctsm5.4.054: CDEPS/CMEPS updates for cplhist Aug 22, 2026
@ekluzek
ekluzek marked this pull request as ready for review August 22, 2026 00:53
Resolve problems with running PLUMBER2 sites

Not b4b for PLUMBER2 sites only.
Details in PR ESCOMP#4092

 Conflicts:
	.gitmodules
@ekluzek ekluzek changed the title ctsm5.4.054: CDEPS/CMEPS updates for cplhist ctsm5.4.054: CDEPS/CMEPS updates for cplhist 1850 ndep from DATM Aug 22, 2026
@ekluzek
ekluzek requested a review from slevis-lmwg August 22, 2026 00:58
@ekluzek

ekluzek commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

Bringing in the updated CMEPS I see that share also has to be updated, and #4182 shows that it's safe to do that.

@ekluzek ekluzek changed the title ctsm5.4.054: CDEPS/CMEPS updates for cplhist 1850 ndep from DATM ctsm5.4.054: CDEPS/CMEPS updates for cplhist and 1850 ndep from DATM Aug 24, 2026
@ekluzek ekluzek moved this from Todo to In Progress in LMWG: Sprint Planning Board Aug 24, 2026

@ekluzek ekluzek left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments to myself.

<default_value>FALSE</default_value>
<values>
<value compset="_CAM" >TRUE</value>
<value compset="_DATM%CPLHIST" >TRUE</value>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Should this just be for 1850 and with CLM60 or all the time? We assume CPLHIST data in CDEPS come from recent cases likely run with CLM60, so this is probably right...

<value compset="_BGC%BDRD" >diagnostic</value>
<value compset="_BGC%BPRP" >prognostic</value>
<value compset="HIST.*_DATM" >diagnostic</value>
<value compset="1850.*_DATM%CPLHIST" >diagnostic</value>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CO2 settings need to be consistent in CLM, DATM and CMEPS. There should be some error checking to check on that. There are various problems that happen if they aren't.

@ekluzek

ekluzek commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

OK, I have changes to make in CDEPS from Bill, so will be working on that.

@wwieder wwieder changed the title ctsm5.4.054: CDEPS/CMEPS updates for cplhist and 1850 ndep from DATM ctsm5.4.055: CDEPS/CMEPS updates for cplhist and 1850 ndep from DATM Aug 27, 2026
@wwieder

wwieder commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Given that this PR is almost ready (except for #4183) and #4183 isn't really required for our CPL_HIST spinup for CESM3, I wonder if this tag could be merged without the CO2 checks to enable a quicker turn around for CESM3 spinup

@ekluzek

ekluzek commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Given that this PR is almost ready (except for #4183) and #4183 isn't really required for our CPL_HIST spinup for CESM3, I wonder if this tag could be merged without the CO2 checks to enable a quicker turn around for CESM3 spinup

I think that's a good idea. I can do that as a seperate thing, and maybe just do it on b4b-dev.

The holdup for this right now isn't that so much, as getting the CDEPS PR to pass review. There's a tricky thing I ran into there requested on the review, that I'll give an update on there.

In the meantime I'm going to merge the submodule update first, since this updates a bunch of submodules and may also need a cime update. It's good to do as a previous step to show that the submodule update is b4b to get ready for just updating the submodules for the changes needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability non-b4b Changes answers (incl. adding tests) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science usability Improve or clarify user-facing options

Projects

Status: In progress - master
Status: In Progress

2 participants