Updates to Core 2.6.0: - #128
Merged
Merged
Conversation
- updates CPM version to quieten warning due to core version update - disables MaCh3 WERROR to allow compilation ignoring may-be-used-uninitialized in core 2.6.0 - duneanaobj dependent build for non-SRProxy separated into new cmake macro in cmake/Modules/fetchduneanaobj.cmake - Fixes various uses of GetFromManager that now require __FILE__/__LINE__ arguments - Moves header inclusion to implementation file in MaCh3DUNEFactory - Updates SampleHandlerBeamFD to use 2.6.0 functional parameters
Charlotte-Knight
approved these changes
Aug 10, 2026
Charlotte-Knight
left a comment
Charlotte-Knight
left a comment
Member
There was a problem hiding this comment.
Seems good to me. I've tested Beam EventRates at nominal values for the systematic parameters, and also at +1 sigma, and the rates agree with pre this PR. So I am happy the functional parameter changes have not broken anything.
I did not run EventRates for atmospherics, but seeing as there no changes there, I suspect no problems. @dbarrow257 have you tried atmospherics with v2.6.0 yet?
Finally, I didn't test the duneanaobj changes. Seeing as it is a refactor, as long as you have tested this @luketpickering, I am happy to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
Updates to track Core release 2.6.0
Changes or fixes
Examples