feat: Use duneanafluxtools - #129
Open
luketpickering wants to merge 3 commits into
Open
Conversation
added 2 commits
August 10, 2026 11:20
- updates CPM version to quieten warning due to core version update - disables MaCh3 WERROR to allow compilation ignoring may-be-used-uninitialized in core 2.6.0 - duneanaobj dependent build for non-SRProxy separated into new cmake macro in cmake/Modules/fetchduneanaobj.cmake - Fixes various uses of GetFromManager that now require __FILE__/__LINE__ arguments - Moves header inclusion to implementation file in MaCh3DUNEFactory - Updates SampleHandlerBeamFD to use 2.6.0 functional parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
Depends on #128 merge that first!
Links in
duneanafluxtools, currently via my repo for testing, but it will be moved to DUNE github org when v1 is ready (soon).Changes or fixes
Examples