Skip to content

Adventure Mode: Internationalization groundwork + Spanish Shandalar localization - #11621

Open
churrufli wants to merge 1 commit into
Card-Forge:masterfrom
churrufli:adventure-translations
Open

Adventure Mode: Internationalization groundwork + Spanish Shandalar localization#11621
churrufli wants to merge 1 commit into
Card-Forge:masterfrom
churrufli:adventure-translations

Conversation

@churrufli

@churrufli churrufli commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

edited 21/08/2026

Summary

Lays the groundwork for translating Adventure Mode and delivers a complete Spanish (es-ES) translation of Shandalar, the default/flagship world:

  • Moves 58 hardcoded English strings in Adventure Mode Java files (NewGameScene, AdventureQuestController, SettingsScene, EventScene, DuelScene, AdventureEventData, EffectData, AdventureQuestData) to the existing Localizer/.properties system.

  • Adds a full Spanish translation of Shandalar's narrative content (quests-es-ES.json, shops-es-ES.json), using a per-language file mechanism that already exists in Config.getFile() but was unused anywhere in the repo: quests.json is transparently replaced by quests-es-ES.json when the UI language is es-ES, with automatic fallback to the English file otherwise. This is the first real use of that per-language file mechanism anywhere in the repo — it existed in Config.getFile() but nothing exercised it before this PR. Any other world or language can follow the same pattern going forward without further engineering work. No Java changes needed for this part, no changes to the English source files.

  • Adds a translation mechanism for NPC/enemy dialog embedded directly in .tmx map files (previously out of scope for this PR, see below — now included). English .tmx files are never touched, duplicated, or require any extra work from maintainers. Translations live in a separate per-locale catalog (dialog-es-ES.json) next to the maps, keyed by map file + object id + position in the dialog tree. Any string missing from the catalog falls back to the English text already in the .tmx, so a partial translation can never break anything,.

  • All 62 .tmx files containing dialog (975 strings) across Shandalar's common maps are translated to es-ES, giving Shandalar full narrative coverage in Spanish.

Scope

Only Shandalar (the default/flagship world) is covered.

@churrufli churrufli changed the title Adventure Mode: Spanish localization UI strings + Shandalar quests/shops Adventure Mode: Internationalization groundwork + Spanish Shandalar localization Aug 15, 2026
@churrufli churrufli added the Adventure For the Adventure Module label Aug 15, 2026
@churrufli
churrufli requested a review from Jetz72 August 23, 2026 22:28
@churrufli
churrufli force-pushed the adventure-translations branch 3 times, most recently from d1a1031 to b371007 Compare August 27, 2026 07:47
@churrufli
churrufli force-pushed the adventure-translations branch from b371007 to 596903b Compare August 27, 2026 08:07
@Jetz72

Jetz72 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

How well does this translation logic hold up in the event the original map or dialog tree is altered, and the person altering it forgets or doesn't know to adjust the translation data accordingly? How easy would it be for us to accidentally create a significant error in a translation that goes unnoticed for months or years?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Adventure For the Adventure Module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants