Adventure Mode: Internationalization groundwork + Spanish Shandalar localization - #11621
Open
churrufli wants to merge 1 commit into
Open
Adventure Mode: Internationalization groundwork + Spanish Shandalar localization#11621churrufli wants to merge 1 commit into
churrufli wants to merge 1 commit into
Conversation
churrufli
force-pushed
the
adventure-translations
branch
3 times, most recently
from
August 27, 2026 07:47
d1a1031 to
b371007
Compare
churrufli
force-pushed
the
adventure-translations
branch
from
August 27, 2026 08:07
b371007 to
596903b
Compare
Contributor
|
How well does this translation logic hold up in the event the original map or dialog tree is altered, and the person altering it forgets or doesn't know to adjust the translation data accordingly? How easy would it be for us to accidentally create a significant error in a translation that goes unnoticed for months or years? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edited 21/08/2026
Summary
Lays the groundwork for translating Adventure Mode and delivers a complete Spanish (es-ES) translation of Shandalar, the default/flagship world:
Moves 58 hardcoded English strings in Adventure Mode Java files (
NewGameScene,AdventureQuestController,SettingsScene,EventScene,DuelScene,AdventureEventData,EffectData,AdventureQuestData) to the existingLocalizer/.propertiessystem.Adds a full Spanish translation of Shandalar's narrative content (
quests-es-ES.json,shops-es-ES.json), using a per-language file mechanism that already exists inConfig.getFile()but was unused anywhere in the repo:quests.jsonis transparently replaced byquests-es-ES.jsonwhen the UI language ises-ES, with automatic fallback to the English file otherwise. This is the first real use of that per-language file mechanism anywhere in the repo — it existed inConfig.getFile()but nothing exercised it before this PR. Any other world or language can follow the same pattern going forward without further engineering work. No Java changes needed for this part, no changes to the English source files.Adds a translation mechanism for NPC/enemy dialog embedded directly in
.tmxmap files (previously out of scope for this PR, see below — now included). English.tmxfiles are never touched, duplicated, or require any extra work from maintainers. Translations live in a separate per-locale catalog (dialog-es-ES.json) next to the maps, keyed by map file + object id + position in the dialog tree. Any string missing from the catalog falls back to the English text already in the.tmx, so a partial translation can never break anything,.All 62
.tmxfiles containing dialog (975 strings) across Shandalar's common maps are translated to es-ES, giving Shandalar full narrative coverage in Spanish.Scope
Only Shandalar (the default/flagship world) is covered.