autotest: remove the script we installed, not the one we installed from - #34095
Open
peterbarker wants to merge 1 commit into
Open
autotest: remove the script we installed, not the one we installed from#34095peterbarker wants to merge 1 commit into
peterbarker wants to merge 1 commit into
Conversation
install_script() honours install_name when choosing the destination, but install_applet_script_context() recorded the source name for removal, so a script installed under a different name was never cleaned up when the context went away. AerobaticsScripting installs Aerobatics/FixedWing/Schedules/AirShow.txt as trick72.txt: context pop then tried to unlink scripts/AirShow.txt, which had never existed, and left scripts/trick72.txt behind after every run. A stale file in scripts/ is loaded by the scripting engine on the next run. install_script_module_context() already resolves install_name this way; do the same here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct tidy-up after script tests - so trick72.txt doesn't linger
Classification & Testing (check all that apply and add your own)
Description
install_script() honours install_name when choosing the destination, but install_applet_script_context() recorded the source name for removal, so a script installed under a different name was never cleaned up when the context went away.
AerobaticsScripting installs Aerobatics/FixedWing/Schedules/AirShow.txt as trick72.txt: context pop then tried to unlink scripts/AirShow.txt, which had never existed, and left scripts/trick72.txt behind after every run. A stale file in scripts/ is loaded by the scripting engine on the next run.
install_script_module_context() already resolves install_name this way; do the same here.