Tools: correct swapped brand_name and manufacturer in brand_map - #34090
Open
peterbarker wants to merge 1 commit into
Open
Tools: correct swapped brand_name and manufacturer in brand_map#34090peterbarker wants to merge 1 commit into
peterbarker wants to merge 1 commit into
Conversation
generate_manifest.py unpacks brand_map values as (brand_name, manufacturer). Four entries were added with the fields the other way around, so the manifest published the vendor as the board name and the board name as the vendor. Only the tuple order changes; the strings are left as they were.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct order of brand/board in generate_manifest.json list
Classification & Testing (check all that apply and add your own)
Description
generate_manifest.py unpacks brand_map values as (brand_name, manufacturer). Four entries were added with the fields the other way around, so the manifest published the vendor as the board name and the board name as the vendor.
Only the tuple order changes; the strings are left as they were.