Plane: tiltrotor: vectoring: correct roll sign and always apply throttle scale

[IamPete1]

Summary

fixes #34041 It seems that vectoring for roll is backwards for tiltrotors. This only has significant effect at high tilt angles (but not at max tilt where there is no room left for vectoring).

Think of the front left motor in vtol flight. It would tilt forwards for CW (positive) yaw. If it were tilted forward then it should tilt up for right (positive) roll. Forward for yaw and up for roll are opposite so the sign in the existing calculation is incorrect.

This also applies the throttle scale factor to both roll and yaw, previously it was applied to yaw only.

Classification & Testing (check all that apply and add your own)

• Checked by a human programmer
• Non-functional change
• No-binary change
• Infrastructure change (e.g. unit tests, helper scripts)
• Automated test(s) verify changes (e.g. unit test, autotest)
• Tested manually, description below (e.g. SITL)
• Tested on hardware
• Logs attached
• Logs available on request

Description

I attempted to come up with a auto test with this and failed. This really needs testing in realflight or IRL.