Copter: add GPS_HACC_GOOD parameter for horizontal accuracy pre-arm c… - #34083
Open
muramura wants to merge 1 commit into
Open
Copter: add GPS_HACC_GOOD parameter for horizontal accuracy pre-arm c…#34083muramura wants to merge 1 commit into
muramura wants to merge 1 commit into
Conversation
…heck Add GPS_HACC_GOOD parameter to ParametersG2 (default 1.5m) to allow enforcing a maximum GPS horizontal accuracy (HAcc) before arming. This improves safety, especially for RTK/high-precision positioning where satellite geometry (HDOP) may look good while actual positional accuracy is still settling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
GPS_HACC_GOODparameter (default: 1.5m) toParametersG2for Copter to enforce a maximum GPS horizontal accuracy requirement during pre-arm checks.Classification & Testing (check all that apply and add your own)
Testing Details:
GPS_HACC_GOOD = 1.5m.LOITERmode with simulated errorSIM_GPS1_ACC = 2.5m(exceeding threshold), pre-arm check failed withPreArm: High GPS HACCand prevented arming.GPS_HACC_GOODto3.0mcleared the error topre-arm goodand allowed arming.GPS_HACC_GOOD = 0disabled the check and allowed arming.esp32s3m5stampfly).Description
Motivation
GPS_HDOP_GOODchecks satellite geometric dilution, checkinghorizontal_accuracyprovides direct assurance that position estimate has converged before arming.GPS_HACC_GOODallows users to enforce a required horizontal accuracy threshold before arming (or set to0to disable).Implementation Details
AP_GPS::horizontal_accuracy(float &hacc)method. If the connected GNSS receiver does not support/report accuracy, the check is safely bypassed.Parameter Details
GPS_HACC_GOODParametersG21.5(meters)0to10(0 disables check)0.1AdvancedAI Disclosure
This contribution was developed with AI pair-programming assistance (Antigravity).