AP_Logger: include disk space details in out-of-space debug messages - #34081
Open
muramura wants to merge 1 commit into
Open
AP_Logger: include disk space details in out-of-space debug messages#34081muramura wants to merge 1 commit into
muramura wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhance "Out of space for logging" debug messages in
AP_Logger_Fileto include available, total, and minimum required disk space details.Classification & Testing (check all that apply and add your own)
Testing Details:
esp32s3m5stampflytarget.avail,total, andminvalues to the MAVLink/MAVProxy console when free space threshold is triggered.AFTER

BEFORE

Description
When
AP_Logger_Fileencounters an "Out of space for logging" condition (during file open, periodic space checks, orENOSPCwrite errors), it previously only printed the generic string"Out of space for logging\n"viaDEV_PRINTF.This made it difficult to diagnose why logging was refused or stopped—for example, whether the filesystem was completely full, or if the available space simply fell below the configured threshold (
_free_space_min_avail/LOG_FILE_MB_FREE).This PR enhances all 3
DEV_PRINTFsites inAP_Logger_File.cppto report:avail: Current available disk space in bytes (disk_space_avail())total: Total disk space in bytes (disk_space())min: Minimum required available space threshold in bytes (_free_space_min_avail)Example Output: