Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mcp-go v1.5.0 has no fixed release for GO-2026-6911 (SSRF/credential leak via unvalidated Location header in client/transport); the fix only lives in unmerged upstream PR #1192. gortex consumes mcp-go as an MCP server (mcp, server, tracing) and never imports the vulnerable client/transport, but the module is flagged at the module level, so ship the patched drop-in under internal/thirdparty/mcp-go alongside go-pointer and renameio. Patch: add client/transport/redirect.go (same-origin CheckRedirect policies) and wire it into oauth.go, sse.go and streamable_http.go per PR #1192. Also bump the vendored module's golang.org/x/text to v0.43.0 (from v0.14.0) and propagate the indirect x/tools v0.51.0, matching the version gortex already resolves via MVS and clearing the Trivy code-scanning findings CVE-2026-56851 / CVE-2026-56852, which otherwise fired on the vendored go.mod even though the real binary is already above the fixed versions. replace github.com/mark3labs/mcp-go => ./internal/thirdparty/mcp-go
zzet
force-pushed
the
fix/mcp-go-ssrf-go-2026-6911
branch
from
November 7, 2026 17:42
2a624f6 to
0c6e7f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The reported dependency vulnerability is GO-2026-6911 - SSRF and credential leak via an unvalidated
Locationheader ingithub.com/mark3labs/mcp-go/client/transport. Gortex depends on the mcp-go module (used as an MCP server), and the scanner flags the module at score 9 even though the vulnerable client-transport package is not imported by gortex's code path.Fix
Upstream has no released fix (v1.5.0, the latest, is still affected; pkg.go.dev reports "all versions, no known fixed"). The fix lives only in unmerged upstream PR #1192, which adds same-origin-only
CheckRedirectpolicies to the default HTTP clients in the client transport.Ship an in-tree patched copy under
internal/thirdparty/mcp-govia areplacedirective, matching the existinggo-pointerandrenameiodrop-in pattern, and bump the require to v1.5.0. The patch applies PR #1192'sredirect.goplus the three default-client wiring edits (oauth.go, sse.go, streamable_http.go).Verification
govulncheckreports no vulnerabilities (was: GO-2026-6911 at v1.4.0 -> v1.5.0).go build ./...succeeds.go mod verify: all modules verified;go mod tidyis idempotent.golangci-lintadds no new issues (3 pre-existing errcheck findings ininternal/mcp/*_test.goare unchanged from base).client/transportunit tests pass.Notes
www/); it is its own module, so it is linted/tested from its own context.replace+ vendored copy.