Repository navigation
Fix malformed z/OS log query strings when optional parameters are combined - #460
Conversation
Signed-off-by: Ashish Kumar Dash <ashishdash2410@gmail.com>
fe71809 to
8afd8c0
Compare
|
Thank you for this PR. I will review. |
|
I merged the request. All looks good. Thanks for identifying this issue. |
|
I will release a new version with this version 6.1.3. |
|
@Ashish-Kumar-Dash FYI — I opened PR #462, which continues the work from this PR and fixes additional inconsistencies in this API. It also led to a different approach for handling URL construction. Given the scope of these changes, I think it makes more sense to include them in version 6.2.0 rather than 6.1.3. This feels like more than a minor patch-level release. |
|
Yes @frankgiordano , I agree. I see your follow-up in #462 addresses the broader issue more cleanly, especially by avoiding client generated time values and simplifying URL construction. Also, I saw some more interesting things while I was going through the codebase, but I'd love if I can run it by you first. Is there a space where you're active, or would you prefer I open straight issues/PR's for it? I came across this project while exploring the Workflow API's mentorship for this repo on LFX, and I'm having a blast going through the codebase as its very structured and not messy, so kudos for that! |
|
@Ashish-Kumar-Dash reach out to me via email giofr01@yahoo.com |
This PR fixes query string construction in
ZosLog.issueCommand().Previously, the
timeparameter was always added first, but optional parameters liketimeRange,direction, andhardcopycould still be appended with?depending onqueryCount. That could produce malformed URLs such as:This change makes query delimiter handling deterministic:
timeis always added first with?&What’s included:
ZosLog.javaZosLogTest.javaValidation:
./mvnw.cmd -q testHey @frankgiordano , I found this potential bug while exploring the codebase & thought it's urgent enough so raised a PR. This matters because malformed query strings can break valid z/OS log requests whenever users combine optional filters. Do lemme know your thoughts! If you want me to raise an issue first for this or from next time onwards , do tell