Add codesys3, crimson, pcworx, and proconos OT protocol modules - #757
Open
Ananya9588 wants to merge 3 commits into
Open
Add codesys3, crimson, pcworx, and proconos OT protocol modules#757Ananya9588 wants to merge 3 commits into
Ananya9588 wants to merge 3 commits into
Conversation
Adds passive fingerprinting scanners for four industrial protocols: CODESYS V3 NameService, Red Lion Crimson CR3, Phoenix Contact PC WorX, and Phoenix Contact/KW-Software ProConOS. Each includes unit tests against a fake local TCP server and a zschema output schema.
# Conflicts: # zgrab2_schemas/zgrab2/__init__.py
- Fix govet shadow warnings (err shadowing) in codesysv3, crimson, pcworx - Preallocate slices per prealloc linter suggestions in codesysv3, crimson, pcworx, proconos test helpers - Add FuzzParseResponse for codesysv3 to satisfy fuzz coverage check
Author
|
All checks passed |
Contributor
|
I was going to contribute my own codesys3 module that is pretty similar so (thumbsup) |
Author
|
OO cool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds passive fingerprinting scan modules for four industrial protocols: CODESYS V3 NameService, Red Lion Crimson CR3, Phoenix Contact PC WorX, and Phoenix Contact/KW-Software ProConOS.
How to Test
Each module has unit tests that spin up a local fake TCP server and exercise the full
Scanner.Scanpath.Notes & Caveats
codesysv3's protocol identifier iscodesys3(pairs with the existingcodesys2module for CODESYS V2), even though the Go package is namedcodesysv3.zgrab2_schemas/zgrab2/for all four modules.integration_tests/service was added for any of these, following the existing precedent set by other niche OT/ICS modules (bacnet,fox,siemens,dnp3,omronfins) which also lack integration tests — I could not find a public Docker image or simulator for any of these four protocols. Happy to add one if a maintainer can point to a suitable real device/simulator.Issue Tracking
N/A — happy to open a discussion issue first if preferred.