feat: add insert batch and streaming rate controls - #813
Merged
XuanYang-cn merged 10 commits intoAug 24, 2026
Conversation
Replace environment and CloudInsert-specific batch sizing with a task-level insert batch size shared by CLI, REST, frontend, datasets, and runners. Keep streaming insert rate case-specific and validate its relationship to batching. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
jamesgao-jpg
force-pushed
the
insert_rate_batch_size_control
branch
from
August 12, 2026 03:59
c4d3bd6 to
302f569
Compare
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Merging zilliztech#843 reintroduced config.NUM_PER_BATCH, which the insert-batch-size control feature removed. Route the AOSS serverless bulk chunk size through the task-level insert_batch_size instead, keeping the default of 100 and the non-positive guard. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
XuanYang-cn
requested changes
Aug 18, 2026
XuanYang-cn
left a comment
Collaborator
There was a problem hiding this comment.
Please address the two inline findings before merging.
Materialize capped qrel-preserving documents during dataset preparation and stream the prepared corpus for filtered and unfiltered loads. This keeps semantic ground truth retrievable without scanning the full raw corpus during timed insertion. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
jamesgao-jpg
force-pushed
the
insert_rate_batch_size_control
branch
from
August 24, 2026 06:08
641cb39 to
64771cd
Compare
Lower the streaming insert rate control minimum to one and rely on the existing batch/rate validation for valid combinations. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
XuanYang-cn
approved these changes
Aug 24, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jamesgao-jpg, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This upstream PR supersedes jamesgao-jpg/VectorDBBench#3.
insert_batch_sizeacross CLI, REST, frontend, datasets, runners, metrics, and load-reuse identitystreaming_insert_ratecase-specific and validate that it is positive, at least the batch size, and divisible by itNUM_PER_BATCHand the Cloud Insert-specific batch option with the common task setting--memorydb-pipeline-batch-size, while accepting the legacy serialized fieldfilter_idCompatibility
--insert-batch-sizeand--streaming-insert-rate--cloud-insert-batch-sizecustom_case.batch_sizeand metricnum_per_batchvalues intoTaskConfig.insert_batch_sizeVerification
make lintmake unittestpython -m pytest -q tests/test_fts_dataset.py(32 passed)python -m pytest -q tests/test_frontend_run_settings.py(5 passed)Signed-off-by: jamesgao-jpg james.gao@zilliz.com