Mark all string parameters as comptime where the C API is expecting string literals. - #7
Open
jhark wants to merge 2 commits into
Open
Mark all string parameters as comptime where the C API is expecting string literals.#7jhark wants to merge 2 commits into
jhark wants to merge 2 commits into
Conversation
…tring literals. Pros: * Prevents mistaken usage of dynamically allocated strings. * Lets us use static constant memory for the source location data. * Avoids generating unnecessary writes to source location data whenever starting a zone. * Matches other Zig Tracy bindings such as the one inside the Zig compiler. Cons: * Breaking API change. * Technically you are allowed to pass non-string literals to these functions, and you might want to if you are dynamically loading code/data containing your strings, or promise to keep your strings allocated until program exit. We could export the raw C API to cover more niche use-cases such as these though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pros:
Cons: