Repository navigation
Rename Dynamic Workers to Dynamic Agents and document tool schema injection - #58
Conversation
Summary of ChangesHello @zby, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation and design specifications for dynamic agent creation and invocation. The primary goal is to standardize terminology by transitioning from 'workers' to 'agents' and to provide clearer guidance on how dynamically generated agents integrate into the runtime, particularly concerning the management and injection of their tool schemas into the session context. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a good step towards standardizing the terminology from 'worker' to 'agent' in the design documentation for dynamic agents. The added section on 'Tool Schema Injection' is a valuable clarification for the implementation. My review focuses on several inconsistencies where the 'worker' terminology still persists. Addressing these will ensure the design document is fully aligned and provides a clear guide for developers.
| - [ ] `agent_create(name, instructions, description, model?)` - write `.worker` file | ||
| - [ ] `agent_call(agent, input, attachments?)` - invoke created agent | ||
| - [ ] Session-scoped registry for created agents (in toolset instance) | ||
| - [ ] Parse created agents via existing `load_worker_file()` / `build_worker_definition()` |
There was a problem hiding this comment.
While the document is being updated to use "agent" terminology, several references to the old "worker" file format and parsing functions remain. For example:
- Line 30:
agent_create(...)is tasked towrite .worker file. - Line 33: Parsing is to be done via
load_worker_file()/build_worker_definition(). - Line 58: The implementation note for
agent_createalso mentions writing a.workerfile.
For consistency, should these be updated to use an .agent file format and corresponding function names (e.g., load_agent_file)? If the .worker format is being intentionally retained, it would be helpful to add a note explaining this decision.
| @@ -1,36 +1,39 @@ | |||
| # Dynamic Workers | |||
| # Dynamic Agents | |||
| ## Context | ||
| - Relevant files: `llm_do/runtime/manifest.py`, `llm_do/runtime/worker_file.py`, `llm_do/runtime/registry.py`, `llm_do/runtime/context.py` | ||
| - Relevant files: `llm_do/runtime/manifest.py`, `llm_do/runtime/worker_file.py`, `llm_do/runtime/registry.py`, `llm_do/runtime/context.py`, `llm_do/runtime/tools.py` | ||
| - Design note: `docs/notes/dynamic-workers-runtime-design.md` |
There was a problem hiding this comment.
The linked design note still points to docs/notes/dynamic-workers-runtime-design.md. This file and its contents should likely also be updated to reflect the new 'agent' terminology to maintain consistency across the documentation.
| - Design note: `docs/notes/dynamic-workers-runtime-design.md` | |
| - Design note: `docs/notes/dynamic-agents-runtime-design.md` |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Motivation
Description
tasks/active/dynamic-workers.mdto "Dynamic Agents", update relevant context to includellm_do/runtime/tools.py, and change toolset naming fromdynamic_workerstodynamic_agentswithagent_create/agent_callAPIs.generated_workers_dirin the manifest viagenerated_workers_dir: str | None = Nonefor created agents.agent_createand include updated tool schemas in subsequent turns.Testing
Codex Task