Skip to content

Ensure TCP connections are properly closed - #152

Merged
thc202 merged 1 commit into
zaproxy:mainfrom
Debakel:main
Dec 9, 2025
Merged

thc202 merged 1 commit into
zaproxy:mainfrom
Debakel:main

Conversation

@Debakel

@Debakel Debakel commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Use a context-managed requests.Session to guarantee that the session and its underlying TCP connections are properly closed.

This prevents ResourceWarning messages being written to stderr.

@psiinon

psiinon commented Sep 9, 2025 •

Copy link
Copy Markdown
Member

Logo
Checkmarx One – Scan Summary & Details – 1ed6024a-0ec0-4a6c-8a81-14dba5026fc3

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to reach out to us for assistance.

Just send a PR comment with @Checkmarx followed by a natural language request.

Examples: @Checkmarx how are you able to help me? @Checkmarx rescan this PR

@thc202

thc202 commented Dec 9, 2025

Copy link
Copy Markdown
Member

Thank you!

Use a context-managed `requests.Session` to guarantee that the session and its underlying TCP connections are properly closed.
This prevents `ResourceWarning` messages being written to stderr.

Signed-off-by: Moritz Duchêne <debakel@users.noreply.github.com>
@thc202

thc202 commented Dec 9, 2025

Copy link
Copy Markdown
Member

Pushed to trigger the checks.

@thc202
thc202 merged commit 33c6e5a into zaproxy:main Dec 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants