Repository navigation
Record input elements with no events - #389
Merged
Merged
Conversation
Member
Author
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to take action directly from this PR:
Try it: |
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
recorder/js-fields
branch
from
October 5, 2026 16:05
93b2373 to
50e98f5
Compare
thc202
approved these changes
Oct 6, 2026
Member
|
Thank you! |
kingthorin
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The ZAP recorder failed to record a field that uses jQuery Inputmask v3.3.4.
The Inputmask hooks keydown/keypress events on the field, so the value is only changed by scripting and the only "notification" of that change is a non-native, jQuery-internal synthetic event, no real native change (or input) event is ever fired on that element, not on each keystroke and not on blur either.
ZAP's recorder adds a plain native element.addEventListener('change', this.handleChange...) listener, and that's the only mechanism it has for capturing typed text (there is no input/keyup listener, and the MutationObserver it uses only watches for added nodes.
Since no native change event is ever dispatched for the field, handleChange is simply never called, and the value is silently dropped.
Fix (source/ContentScript/recorder.ts):