except asyncio.IncompleteReadError insteed of ConnectionError - #45
Open
Jonney wants to merge 2 commits into
Open
except asyncio.IncompleteReadError insteed of ConnectionError#45Jonney wants to merge 2 commits into
Jonney wants to merge 2 commits into
Conversation
According to the asyncio documentation (https://docs.python.org/3/library/asyncio-stream.html#asyncio.StreamReader.readexactly), readexactly() will raise asyncio.IncompleteReadError, not ConnectionError. If asyncio.IncompleteReadError is not caught, we will get "Task exception was never retrieved."
ConnectionError is also necessary.
ruslan-korneev
suggested changes
Apr 12, 2025
| try: | ||
| data = await self.reader.readexactly(data_len) | ||
| except ConnectionError: | ||
| except (ConnectionError|asyncio.IncompleteReadError): |
There was a problem hiding this comment.
this not gonna work with pipe, try comma:
except (ConnectionError, IncompleteReadError):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the asyncio documentation, readexactly() will raise asyncio.IncompleteReadError, not ConnectionError.
If asyncio.IncompleteReadError is not caught, we will get "Task exception was never retrieved."