highload wallet v3 implementation - #32
Open
liminalAngel wants to merge 8 commits into
Open
Conversation
provided highload v3 implementation
|
|
||
| return await self.send_external(body=transfer_msg) | ||
|
|
||
| async def transfer(self, destination: typing.Union[Address, str], amount: int, sendmode: int, created_at: int, timeout: int, body: Cell = Cell.empty(), state_init: StateInit = None): |
Contributor
There was a problem hiding this comment.
body: Cell = Cell.empty()
Do not create objects inside function signature except the cases you exactly understand what are you doing.
In [1]: from pytoniq_core import Cell
...:
...:
...: def f(b: Cell = Cell.empty()):
...: b.bits.append(1)
...: print(b.bits)
...:
...: f()
...: f()
...:
bitarray('1')
bitarray('11')| return mnemo, await cls.from_mnemonic(provider=provider, mnemonics=mnemo, wc=wc, wallet_id=wallet_id, timeout=timeout) | ||
|
|
||
| @staticmethod | ||
| def raw_create_transfer_msg(private_key: bytes, wallet_id: int, sendmode: int, created_at: int, timeout: int, message_to_send: WalletMessage, query_id: HighloadQueryId = 0) -> Cell: |
Contributor
There was a problem hiding this comment.
query_id: HighloadQueryId = 0
looks like the default value is invalid
| """ | ||
| :return: is query processed from wallet's get method | ||
| """ | ||
| return (await super().run_get_method(method='processed?', stack=[query_id]))[0] No newline at end of file |
Contributor
There was a problem hiding this comment.
whats wrong with empty lines at the end of files ?
|
|
||
| async def raw_transfer(self, sendmode: int, created_at: int, timeout: int, msg: WalletMessage, query_id: HighloadQueryId = 0): | ||
| """ | ||
| :param sendmode: sendmode |
Contributor
There was a problem hiding this comment.
may be send_mode instead ?
| result_msg = self.create_wallet_internal_message(destination=destination, value=amount, body=body, state_init=state_init) | ||
| return await self.raw_transfer(sendmode=sendmode, created_at=created_at, timeout=timeout, msg=result_msg) | ||
|
|
||
| async def send_init_external(self, sendmode: int, created_at: int, timeout: int, message_to_send: WalletMessage): |
Contributor
There was a problem hiding this comment.
In my opinion, this is good place to set default values.
For example, I don't think many users will really understand meaning of timeout var and how it works. Let's advice some value.
| .store_cell(signing_message) \ | ||
| .end_cell() | ||
|
|
||
| async def raw_transfer(self, sendmode: int, created_at: int, timeout: int, msg: WalletMessage, query_id: HighloadQueryId = 0): |
Contributor
There was a problem hiding this comment.
Do we really want to be able to send only one message per transaction?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provided highload wallet v3 implementation