frontends/swift: add SpeciesFractions-derived fields and fix scalar conversion - #5497
Open
Stanley-Lee-glitch wants to merge 1 commit into
Open
frontends/swift: add SpeciesFractions-derived fields and fix scalar conversion#5497Stanley-Lee-glitch wants to merge 1 commit into
Stanley-Lee-glitch wants to merge 1 commit into
Conversation
…s, array to scalar bug fixed in data_structure
Stanley-Lee-glitch
marked this pull request as draft
July 28, 2026 09:43
Stanley-Lee-glitch
marked this pull request as ready for review
July 28, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds derived per-species fraction fields for the SWIFT frontend by unpacking the packed SpeciesFractions particle field. For each ion and molecule in the chemistry network, it exposes:
In addition, this PR fixes several array-to-scalar conversion issues in SwiftDataset by converting HDF5 scalar arrays to Python scalars using np.asarray(...).item(). This avoids failures when metadata are returned as NumPy arrays instead of scalar values.
PR Checklist