BUG: Allow MD5 fingerprints in FIPS mode - #5490
Open
Kkkakania wants to merge 1 commit into
Open
Conversation
|
Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
All MD5 usage in yt is for dataset/cache identifiers or answer-test fingerprints, not for security. This change passes
usedforsecurity=Falseat every MD5 constructor so yt can run on Python builds that block MD5 in FIPS mode while preserving the existing digest algorithm and stored answer hashes.The regression test simulates FIPS behavior for byte,
None, and nested dictionary hashing paths and verifies that each digest remains unchanged.Fixes #5172.
PR Checklist
Verification
python -m pytest yt/utilities/tests/test_answer_testing.py -q(3 passed)python -m pytest yt/utilities/tests -q(48 passed, 1 skipped)python -m pytest yt/data_objects/tests/test_data_containers.py -q(7 passed, 2 skipped)uvx pre-commit run --files ...on all seven changed files (all applicable hooks passed)AI assistance
OpenAI Codex assisted with issue investigation, implementation, testing, and PR drafting. No private data or generated assets are included.