Skip to content

BUG: convert to code_length to ensure consistent units #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cphyc wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

BUG: convert to code_length to ensure consistent units #5469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions yt/data_objects/selection_objects/region.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,16 @@ def __init__(
self.left_edge = self.ds.arr(left_edge, "code_length", dtype="float64")
else:
# need to assign this dataset's unit registry to the YTArray
self.left_edge = self.ds.arr(left_edge.copy(), dtype="float64")
# and convert to code_length to ensure consistent units for selection
left_edge_arr = self.ds.arr(left_edge.copy(), dtype="float64")
self.left_edge = left_edge_arr.to("code_length")
if not isinstance(right_edge, YTArray):
self.right_edge = self.ds.arr(right_edge, "code_length", dtype="float64")
else:
# need to assign this dataset's unit registry to the YTArray
self.right_edge = self.ds.arr(right_edge.copy(), dtype="float64")
# and convert to code_length to ensure consistent units for selection
right_edge_arr = self.ds.arr(right_edge.copy(), dtype="float64")
self.right_edge = right_edge_arr.to("code_length")

def _get_bbox(self):
"""
Expand Down
Loading