labels... again :D - #551
Merged
Merged
Conversation
The button groups these labels sit in are already titled "Timer picker style" and "Volume buttons during alarm", so the option text only needs to name the choice.
The about entry repeated the app name as its title and buried the word "version" in the summary, so the preference read as a second source code link until the summary was scanned. Title it "Clock You version" and leave the summary to the value itself. Weblate removes the translations of the replaced string on its next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this follows up on the wording pass in #542, and touches labels from #530 and #545.
shorten "Number pad" to "Numpad", "Control volume" to "Volume", "Do nothing" to "Nothing" so the shorter labels also sit better in the segmented buttons I had to widen in #545.
the About entry shows "Clock You" with "Version 1.2.3 (45)" underneath, which reads like a second Source code link until you reach the summary. this titles it "Clock You version" and leaves the value on its own.
that orphans
versionin 38 locales, which lint flags asExtraTranslation, so I removed those in the same commit. the two new strings ship untranslated for the translation workflow to pick up.