Changes to support htmlwidgets integration - #86
Open
dmurdoch wants to merge 3 commits into
Open
Conversation
This allows code like htmlwidgets to modify it.
(so `htmlwidgets` can ask for recent changes).
This was referenced Apr 20, 2025
yihui
force-pushed
the
main
branch
3 times, most recently
from
April 4, 2026 04:33
554cb21 to
2f9edb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes two things:
mark()to allowmetato be specified as a chunk option. This will allow an htmlwidgetrecord_print()method to insert dependencies.I considered some other ways to do this:
a. Use the
litedown.html.metaoption. The problem with this is that there doesn't seem to be a way to restore that option at the end of the run, whereasfuse()does restorereactor()values.b. Add a new function that code could use to set options. This seems unnecessarily complicated.
c. Use Javascript methods directly. The problem with this is that some dependencies could end up inserted multiple times.
gen_tag()so that a file dependency can be specified as an absolute path. That's howhtmltools::resolveDependencies()will produce them.It would be possible to convert those absolute paths to relative paths, but that seems kludgy.
This code works with the
litedownbranch of https://github.com/dmurdoch/htmlwidgets .