Skip to content

Roll the offer back when a re-INVITE cannot be sent #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
23Skidoo wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Draft

Roll the offer back when a re-INVITE cannot be sent #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/api/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,16 @@ export abstract class Session {
this.logger.error(error.message);
this.logger.error("Failed to send re-INVITE");
this.pendingReinvite = false;
throw error;
// The offer was applied before the send failed, so undo it; otherwise
// the next attempt cannot create a description at all.
return this.rollbackOffer()
.catch((rollbackError: Error) => {
this.logger.error(rollbackError.message);
this.logger.error("Failed to rollback offer after a failed re-INVITE");
})
.then(() => {
throw error;
});
});
}

Expand Down