Add Node.js 24 support and fix security vulnerabilities in dependencies - #258
Conversation
|
Thanks for the draft PR. I am not merging this in the current form yet.\n\nMain concerns:\n1. 2.x requires Node >=18, but still declares . Merging this would silently drop Node 14/16 support for users.\n2. This should be aligned with current first (workflow changes have moved on).\n3. The PR mixes CI matrix changes + dependency/security updates in one bundle, which makes rollout riskier.\n\nSuggested next update:\n- Rebase onto latest .\n- Either:\n - keep Node 14/16 compatibility (do not upgrade to a runtime-incompatible dependency), or\n - explicitly move to Node >=18 with a semver-major release plan and update .\n- Split into focused PRs if possible (CI/workflow vs dependency bump).\n- Mark ready for review after above updates.\n\nHappy to re-review once updated. |
|
Thanks for the draft PR. I am not merging this in the current form yet. Main concerns:
Suggested next update:
Happy to re-review once updated. |
a1a35e7 to
e01ec4e
Compare
No pre-built binaries were published for Node.js 24, and the CI/release workflows never included it. Additionally,
@mapbox/node-pre-gyp@1.xpulled in vulnerable versions oftarand related packages.Changes
test.yml,github_release.yml): Added24.xtonode-versionmatrix across all platforms (Linux, macOS, Windows)@mapbox/node-pre-gyp: Bumped from^1.0.10→^2.0.3, fixing high-severitytarvulnerabilitiespackage-lock.json: Updated transitive devDependency vulnerabilities (minimatch,js-yaml,diff) vianpm audit fixOne remaining known vulnerability:
serialize-javascriptviamocha(devDependency only, no user-facing impact) — no non-breaking fix exists asmocha@11still depends on the vulnerable range.Original prompt
This section details on the original issue you should resolve
<issue_title>[bug] 不支持 Node.js 24 和 Linux</issue_title>
<issue_description>@yanyiwu 我的 JieBa 项目升级到 Node.js 24 后 GitHub actions 流水线全线崩溃……
全版本不支持 Node.js 24
Node.js 22 安装成功,24 安装报错如下: