Clarify topic message sending docs - #300
Merged
Merged
Conversation
xtrinch
changed the title
xtrinch
marked this pull request as ready for review
April 7, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the README examples related to topic messaging so they use
FCMDevice.send_topic_message(...)instead ofsend_message().Why
Discussion #249 showed that the docs still implied a topic-targeted
Messagecould be sent through the device/queryset send API. That usage is misleading because topic sends should go through the topic-specific API.Impact
The documentation now reflects the intended Firebase/topic workflow more clearly and avoids pointing users at an invalid pattern.