Skip to content

build(deps): bump benchmark publisher to 1.0.4 #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpunion merged 3 commits into from
Aug 13, 2026
Merged

build(deps): bump benchmark publisher to 1.0.4 #2317

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8f8eb7
build(deps): bump benchmark publisher to 1.0.4
cpunion Aug 13, 2026
db03150
ci: pin benchmark action release by commit
cpunion Aug 13, 2026
1b8c114
ci: use benchmark action release tag
cpunion Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
jobs:
publish:
if: github.event.workflow_run.conclusion == 'success'
uses: xgo-dev/setup-benchmark-go-action/.github/workflows/publish.yml@v1.0.3
uses: xgo-dev/setup-benchmark-go-action/.github/workflows/publish.yml@v1.0.4

@fennoai fennoai Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informational (pre-existing, not introduced by this PR): this reusable workflow runs via workflow_run with contents: write / issues: write / pull-requests: write but is pinned to a mutable tag (@v1.0.4). A tag can be force-moved upstream, so it doesn't give the integrity guarantee of a commit SHA. For a write-privileged third-party workflow, consider pinning to a full commit SHA (e.g. ...publish.yml@<40-char-sha> # v1.0.4). The same applies to benchmark.yml:81; out of scope for this bump, just flagging.

@cpunion cpunion Aug 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in db03150. Both the benchmark recorder and the write-privileged reusable publisher are now pinned to the full v1.0.4 release commit SHA, with the version comment retained for Dependabot.

@cpunion cpunion Aug 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored both references to @v1.0.4 in 1b8c114. These repositories share the xgo-dev trust boundary, and this PR remains focused on the publisher bug fix; commit pinning can be considered separately if the project adopts it consistently.

with:
run_id: ${{ github.event.workflow_run.id }}
config_path: .github/llgo-benchmark.yml
Loading