Skip to content

test/goroot: classify precise GC and nil-check cases #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpunion merged 5 commits into from
Aug 13, 2026
Merged

test/goroot: classify precise GC and nil-check cases #2313

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
889bb6f
test/goroot: classify compiler diagnostics as not applicable
cpunion Aug 13, 2026
a45dbe3
test/goroot: classify precise GC liveness as not applicable
cpunion Aug 13, 2026
4b255c2
test/goroot: clarify diagnostic exclusions
cpunion Aug 13, 2026
087c8a8
test/goroot: classify remaining precise GC cases
cpunion Aug 13, 2026
0efe2c7
test/goroot: classify remaining nil-check cases
cpunion Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions test/goroot/notapplicable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,22 @@
# counted as remaining compatibility xfails. Every entry names the mechanism
# under test and explains the LLGo design choice that puts it out of scope.
not_applicable:
- version: go1.26
directive: errorcheck
case: fixedbugs/issue4776.go
reason: "not applicable: this case asserts cmd/compile's exact missing-package-clause diagnostic; LLGo uses its own parser and diagnostic pipeline and does not reproduce cmd/compile diagnostic text; matching this toolchain-specific output is not an LLGo compatibility goal"
- version: go1.26
directive: errorcheck
case: fixedbugs/issue13266.go
reason: "not applicable: this case asserts cmd/compile's exact malformed-package-clause diagnostic; LLGo uses its own parser and diagnostic pipeline and does not reproduce cmd/compile diagnostic text; matching this toolchain-specific output is not an LLGo compatibility goal"
- version: go1.26
directive: errorcheck
case: fixedbugs/issue20789.go
reason: "not applicable: this case asserts cmd/compile's exact malformed-name diagnostic; LLGo uses its own parser and diagnostic pipeline and does not reproduce cmd/compile diagnostic text; matching this toolchain-specific output is not an LLGo compatibility goal"
- version: go1.26
directive: errorcheck
case: fixedbugs/bug050.go
reason: "not applicable: this case asserts cmd/compile's exact malformed-declaration diagnostics; LLGo uses its own parser and diagnostic pipeline and does not reproduce cmd/compile diagnostic count and text; matching this toolchain-specific output is not an LLGo compatibility goal"
Comment thread
cpunion marked this conversation as resolved.
Outdated
- version: go1.26
directive: errorcheck
case: escape_array.go
Expand Down
16 changes: 0 additions & 16 deletions test/goroot/xfail.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,26 +1277,10 @@ flakes:
case: fixedbugs/issue25897a.go
reason: reflect-generated goroutines under a single-P continuous-GC loop can complete or exceed the 1m run timeout on darwin/arm64
xfails:
- version: go1.26
directive: errorcheck
case: fixedbugs/issue4776.go
reason: llgo parser uses a different missing-package-clause diagnostic
- version: go1.26
directive: errorcheck
case: fixedbugs/issue4405.go
reason: llgo parser recovery emits additional malformed-statement diagnostics
- version: go1.26
directive: errorcheck
case: fixedbugs/issue13266.go
reason: llgo parser uses a different malformed-package-clause diagnostic
- version: go1.26
directive: errorcheck
case: fixedbugs/issue20789.go
reason: llgo parser does not emit the expected malformed-name diagnostic
- version: go1.26
directive: errorcheck
case: fixedbugs/bug050.go
reason: llgo parser emits an additional malformed-declaration diagnostic
- version: go1.26
directive: errorcheck
case: bombad.go
Expand Down
Loading