Update cstruct to 4.0 and its dependents - #387
Merged
Merged
Conversation
This is necessary to support newer cstruct packages without importing the full history of the nocrypto, as it hasn't had a release for more than 2 years. The compile option to disallow hardware acceleration has been kept from our previous package definition. Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
also update x509 to 0.6.3 as it needs to be updated at the same time
Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
edwintorok
approved these changes
May 22, 2019
| "0003-Auto-detect-ppx_sexp_conv-runtime-library.patch" | ||
| "0004-pack-package-workaround-ocamlbuild-272.patch" | ||
| "0005-use-modern-cstruct-findlib.patch" | ||
| "0006-explicit-dependency-on-sexplib.patch" |
Member
There was a problem hiding this comment.
This package has accumulated quite a few packaging patches, looks like upstream hasn't made a release (or merged PRs) in quite a while
Member
Author
There was a problem hiding this comment.
While the latest release was done in 2017, master was last updated on February. The PR for porting the build system to dune got stuck on early April: mirleft/ocaml-nocrypto#158
lindig
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nocryptohas been changed to have the same patches as the default opam repository. The only difference is that the flag"--accelerate" "false"was kept.cstruct-sexplibhas been added as it's needed byx509.0.6.3.It looks like it's next version is going to break API and also drop the dependency.