Lag spike due to data not being saved asynchronous

[Brend-Smits]

Running Sky Factory 3 with about 50 players online.
My lag spike profiler tells me that Simple Achievement is the cause of some of my lag spikes.

Check the above screenshot for more information.
Would it be possible for you to integrate asynchronous saving?
Especially on large servers you will notice this change.

[tterrag1098]

I plan to make saves per-player which should mitigate this problem without the added complexity of threaded saves, as the json for a single player is a static size. Though as SA only saves on world save, so you might want to check that none of your mods are spamming world saves.

[Brend-Smits]

Thank you for your reply.
I've increased the interval for auto saves in the mean while.
Looking forward to the update!

Keep me posted please!

[Speiger]

@tterrag1098 i have a fixed version that improves saving speed by quite a lot. Sadly i am unable to export it since forge seems to be offline right now. Would you accept a pullrequest if i did one?

[tterrag1098]

I can't say whether I would accept it without seeing the changes. But a PR would definitely be appreciated.

…

On Sat, Mar 25, 2017 at 10:36 AM, Speiger ***@***.***> wrote: @tterrag1098 <https://github.com/tterrag1098> i have a fixed version that improves saving speed by quite a lot. Sadly i am unable to export it since forge seems to be offline right now. Would you accept a pullrequest if i did one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADk-8O7ibUKHLa7SQeeSdYr-80xCR1x3ks5rpSZhgaJpZM4MV2-n> .

[Speiger]

@tterrag1098 there is a fix posted. but i had to fix a class since forge servers werent accessable from my point. So you would have to fix a Class with the ToString tag because i had to remove it else it would let me compile... (Custom workspace)

[tterrag1098]

Forge is not offline, I'm not sure what you mean. Are you trying to compile from an IDE? If so, make sure you have the lombok plugin.

[Speiger]

well i dont have it...

[tterrag1098]

So...get it? Takes a few seconds only https://projectlombok.org/download.html

[Speiger]

@tterrag1098 its faster to take the pull to change 1 function.
I would have to redo my whole project. Install a library to gradlew that i do not even know.
On top of that i am going to sleep any second.