You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request fixes the failing QML format job by adding a command fallback since the binary location changed on Arch Linux. It also updates the flatpak external data checker configuration for libebur128 to use git tags in order to avoid GitHub API rate limits that were causing the Flatpak lint job to fail.
Crucially, it also resolves the root cause of the segmentation fault tracked in #5120. In Qt 6.7, a known issue causes the QML engine to occasionally segfault when initializing components if Javascript array syntax ([]) is used to assign to QML list properties like actions. Because actions is the default property of Kirigami.ActionToolBar, we can safely omit the actions: [] wrapper. This removes the array conversion, completely fixing the random runtime segfaults.
Crucially, it also resolves the root cause of the segmentation fault tracked in #5120. In Qt 6.7, a known issue causes the QML engine to occasionally segfault when initializing components if Javascript array syntax ([]) is used to assign to QML list properties like actions
Although I am not a fan of the proposed syntax using it isn't the end of the world. But I wonder if that is actually the fix for #5120. At least in our latest flatpak package release Qt 6.7 is not used. It uses 6.10.3.
And it seems qt 6.7 has already reached end of life. Are there still many distributions using it when compiling easyeffects native packages? As users on older system usually use our Flatpak package I prefer to write the source code targeting more recent library versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the failing QML format job by adding a command fallback since the binary location changed on Arch Linux. It also updates the flatpak external data checker configuration for libebur128 to use git tags in order to avoid GitHub API rate limits that were causing the Flatpak lint job to fail.
Crucially, it also resolves the root cause of the segmentation fault tracked in #5120. In Qt 6.7, a known issue causes the QML engine to occasionally segfault when initializing components if Javascript array syntax (
[]) is used to assign to QML list properties likeactions. Becauseactionsis the default property ofKirigami.ActionToolBar, we can safely omit theactions: []wrapper. This removes the array conversion, completely fixing the random runtime segfaults.Closes #5120