docs(guides): split the per-product login walkthroughs into their own guides - #51
Conversation
|
Warning Review limit reached
Next review available in: 15 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary
WalkthroughThe login documentation now separates product-specific registration from the shared login workflow. New Asgardeo and Identity Server 7.x guides document registration, tokens, audiences, trust, CI credentials, and browserless login. The ThunderID guide now points to the shared workflow. The main guide has renumbered sections and product-specific guidance. Research, README, smoke-run, configuration, environment, and test references were updated. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/guides/login.md (1)
57-61: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winUse product-neutral terminology for the protected resource.
The shared requirement says every deployment needs an API resource. Thunder configures a resource server and sends its URI as the resource indicator. Replace
API resourcewith a product-neutral term such asprotected resource, and keep product-specific object names in each walkthrough.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/guides/login.md` around lines 57 - 61, Replace the product-specific “API resource” wording in the JWT access-token description with “protected resource,” while preserving the existing explanation and product-specific object names in the walkthroughs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/guides/login-identity-server.md`:
- Around line 113-127: Reorder the certificate setup in the guide so the primary
procedure creates or installs a deployment-specific keypair or CA whose private
key is uniquely held by the operator. Move the existing default WSO2 certificate
trust commands into an explicitly temporary local fallback section, retaining
the warnings, TLS scoping, login-keychain limitation, and cleanup command.
In `@docs/guides/login.md`:
- Line 380: Update the CI configuration guidance around the product-specific
identity block and the Thunder audience section to use product-correct values
for type, issuer, endpoint, tenant, provider, and absolute resource-server URI;
direct readers to the corresponding identity block in section 2.2 or provide
separate CI examples for each product, and describe Thunder’s value as the
resource-server URI rather than a resource identifier.
---
Outside diff comments:
In `@docs/guides/login.md`:
- Around line 57-61: Replace the product-specific “API resource” wording in the
JWT access-token description with “protected resource,” while preserving the
existing explanation and product-specific object names in the walkthroughs.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 66cc55c5-7b38-48d8-8b25-579b09522b51
📒 Files selected for processing (11)
docs/README.mddocs/guides/login-asgardeo.mddocs/guides/login-identity-server.mddocs/guides/login-thunder.mddocs/guides/login.mddocs/research/asgardeo-redirect-uri-and-scope-narrowing.mddocs/research/product-authentication-compatibility.mdtest/smoke/RUNNING.mdtest/smoke/config.gotest/smoke/env.exampletest/smoke/login_smoke_test.go
2 participants
Closes #45.
docs/guides/login.mdintologin-asgardeo.mdandlogin-identity-server.md, beside the existinglogin-thunder.md.login.mdis now the product-generic path only: what the shell needs, writing the context document, logging in, CI, troubleshooting, proving it. 1090 → 783 lines. §4–§9 renumbered to §2–§7.audbehaviour and its measurement date — the one value that is not portable between products.login.md§5 keeps the context document and job wiring.login.md; only single-product failures live in a product guide.docs/README.md,test/smoke/RUNNING.md,test/smoke/env.example,config.go,login_smoke_test.go, and both research docs. Every relative link and in-guide anchor was checked to resolve.make test,make lint(both tag sets), andmake smoke-buildall pass.